Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Type Hints] nn.InstanceNorm #5684

Merged
merged 6 commits into from
Oct 13, 2022
Merged

[Type Hints] nn.InstanceNorm #5684

merged 6 commits into from
Oct 13, 2022

Conversation

wwymak
Copy link
Contributor

@wwymak wwymak commented Oct 13, 2022

The test for nn.InstanceNorm already has a test for torchscript support, so I have not changed that file

rusty1s
rusty1s approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

torch_geometric/nn/norm/instance_norm.py Outdated Show resolved Hide resolved
@rusty1s rusty1s changed the title Add type hint for nn.InstanceNorm [Type Hints] nn.InstanceNorm Oct 13, 2022
@rusty1s rusty1s marked this pull request as ready for review October 13, 2022 18:23
@rusty1s rusty1s mentioned this pull request Oct 13, 2022
Closed
@codecov
Copy link

codecov bot commented Oct 13, 2022 •
edited
Loading

Codecov Report

Merging #5684 (340a7b6) into master (be6ac29) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 340a7b6 differs from pull request most recent head 2026c40. Consider uploading reports for the commit 2026c40 to get more accurate results

@@           Coverage Diff           @@
##           master    #5684   +/-   ##
=======================================
  Coverage   83.80%   83.80%           
=======================================
  Files         349      349           
  Lines       19235    19235           
=======================================
  Hits        16119    16119           
  Misses       3116     3116
Impacted Files Coverage Δ
torch_geometric/nn/norm/instance_norm.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s enabled auto-merge (squash) October 13, 2022 18:33
@rusty1s rusty1s merged commit c6ef4a0 into pyg-team:master Oct 13, 2022
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
@wwymak @rusty1s
@pre-commit-ci @JakubPietrakIntel
[Type Hints] nn.InstanceNorm (pyg-team#5684)
ad18867 
The test for nn.InstanceNorm already has a test for torchscript support,
so I have not changed that file

Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

Assignees

@wwymak wwymak

Labels
0 - Priority P0 type hints utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wwymak @rusty1s