Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Type Hints] transforms.Distance #5685

Merged
merged 20 commits into from
Oct 14, 2022
Merged

[Type Hints] transforms.Distance #5685

merged 20 commits into from
Oct 14, 2022

Conversation

sachinsharma9780
Copy link
Contributor

No description provided.

sachinsharma9780 and others added 16 commits October 13, 2022 01:22
@sachinsharma9780
add type hints dense_sage_conv
68ab956
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
1f8aa17 
for more information, see https://pre-commit.ci
@sachinsharma9780
adding PR number for improved type hint support
0dc28d6
@sachinsharma9780
Merge branch 'master' of https://github.com/sachinsharma9780/pytorch_…
6c3aa8c 
…geometric

merge with changelog.md file
@sachinsharma9780
adding BoolTensor type to mask argument
590b0fb
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
87e85ab 
for more information, see https://pre-commit.ci
@sachinsharma9780
add type hints dense_gcn_conv
1b07460
@sachinsharma9780
Merge branch 'master' of https://github.com/sachinsharma9780/pytorch_…
0b049e3 
…geometric
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
fd858a6 
for more information, see https://pre-commit.ci
@rusty1s
Merge branch 'master' into master
c1cb37b
@rusty1s
update
2ab0361
@rusty1s
Merge branch 'master' into master
fdf9f54
@rusty1s
Changelog
5ac1b73
@sachinsharma9780
add type hints transforms/distance
1ee2cf8
@sachinsharma9780
Merge branch 'master' of https://github.com/sachinsharma9780/pytorch_…
0aad980 
…geometric
@sachinsharma9780
adding type hints support in transform/distance
ca2064f
@EdisonLeeeee EdisonLeeeee changed the title [Type Hints] Transforms Distance [Type Hints] transforms.Distance, nn.DenseGCNConv, and nn.DenseSAGEConv Oct 14, 2022
@rusty1s rusty1s changed the title [Type Hints] transforms.Distance, nn.DenseGCNConv, and nn.DenseSAGEConv [Type Hints] transforms.Distance Oct 14, 2022
rusty1s
rusty1s approved these changes Oct 14, 2022
View reviewed changes
torch_geometric/transforms/distance.py Outdated Show resolved Hide resolved
@rusty1s rusty1s mentioned this pull request Oct 14, 2022
Closed
@rusty1s rusty1s enabled auto-merge (squash) October 14, 2022 08:04
@rusty1s rusty1s removed the nn label Oct 14, 2022
@codecov
Copy link

codecov bot commented Oct 14, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@ee0bec9). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 5f3a2b2 differs from pull request most recent head 9335739. Consider uploading reports for the commit 9335739 to get more accurate results

@@            Coverage Diff            @@
##             master    #5685   +/-   ##
=========================================
  Coverage          ?   83.80%           
=========================================
  Files             ?      349           
  Lines             ?    19239           
  Branches          ?        0           
=========================================
  Hits              ?    16123           
  Misses            ?     3116           
  Partials          ?        0
Impacted Files Coverage Δ
torch_geometric/transforms/distance.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s merged commit 522d85a into pyg-team:master Oct 14, 2022
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
@sachinsharma9780 @pre-commit-ci
@rusty1s @JakubPietrakIntel
[Type Hints] transforms.Distance (pyg-team#5685)
e1d694f 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

Assignees

@sachinsharma9780 sachinsharma9780

Labels
0 - Priority P0 transform type hints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sachinsharma9780 @rusty1s @EdisonLeeeee