Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Type Hints] transforms.Spherical and transforms.PointPairFeatures #5732

Merged

Conversation

TanveshT
Copy link
Contributor

Changes

  • added type hints to transforms.Spherical and transforms.PointPairFeatures

@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Merging #5732 (0827a62) into master (bd970d2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5732   +/-   ##
=======================================
  Coverage   84.03%   84.04%           
=======================================
  Files         349      349           
  Lines       19308    19311    +3     
=======================================
+ Hits        16226    16229    +3     
  Misses       3082     3082           
Impacted Files Coverage Δ
torch_geometric/transforms/point_pair_features.py 100.00% <100.00%> (ø)
torch_geometric/transforms/spherical.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

torch_geometric/transforms/spherical.py Outdated Show resolved Hide resolved
@rusty1s rusty1s merged commit a6c83c2 into pyg-team:master Oct 17, 2022
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
pyg-team#5732)

## Changes

- added type hints to `transforms.Spherical` and
`transforms.PointPairFeatures`

Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants