Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Type Hints] transforms.SIGN, utils.to_scipy_sparse_matrix and utils.from_scipy_sparse_matrix #5736

Merged
merged 11 commits into from
Oct 17, 2022

Conversation

venomouscyanide
Copy link
Contributor

@venomouscyanide venomouscyanide commented Oct 16, 2022

Added Type Hint support for the following: transforms.SIGN, utils.to_scipy_sparse_matrix and utils.from_scipy_sparse_matrix

@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Merging #5736 (ab45cf2) into master (a768d7b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head ab45cf2 differs from pull request most recent head 1444a38. Consider uploading reports for the commit 1444a38 to get more accurate results

@@           Coverage Diff           @@
##           master    #5736   +/-   ##
=======================================
  Coverage   84.04%   84.04%           
=======================================
  Files         349      349           
  Lines       19319    19320    +1     
=======================================
+ Hits        16237    16238    +1     
  Misses       3082     3082           
Impacted Files Coverage Δ
torch_geometric/transforms/sign.py 40.00% <100.00%> (+2.50%) ⬆️
torch_geometric/utils/convert.py 85.81% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@venomouscyanide venomouscyanide changed the title Add TypeHints to transforms.SIGN, utils.to_scipy_sparse_matrix and ut… [Type Hints] transforms.SIGN, utils.to_scipy_sparse_matrix and utils.from_scipy_sparse_matrix Oct 16, 2022
@venomouscyanide venomouscyanide marked this pull request as ready for review October 16, 2022 18:24
@venomouscyanide venomouscyanide changed the title [Type Hints] transforms.SIGN, utils.to_scipy_sparse_matrix and utils.from_scipy_sparse_matrix [Type Hints] transforms.SIGN, utils.to_scipy_sparse_matrix and utils.from_scipy_sparse_matrix Oct 16, 2022
torch_geometric/utils/convert.py Outdated Show resolved Hide resolved
torch_geometric/utils/convert.py Show resolved Hide resolved
@rusty1s rusty1s changed the title [Type Hints] transforms.SIGN, utils.to_scipy_sparse_matrix and utils.from_scipy_sparse_matrix [Type Hints] transforms.SIGN, utils.to_scipy_sparse_matrix and utils.from_scipy_sparse_matrix Oct 17, 2022
@rusty1s rusty1s enabled auto-merge (squash) October 17, 2022 06:20
auto-merge was automatically disabled October 17, 2022 12:27

Head branch was pushed to by a user without write access

@rusty1s rusty1s enabled auto-merge (squash) October 17, 2022 12:35
@rusty1s rusty1s merged commit 4cc5e6d into pyg-team:master Oct 17, 2022
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
…tils.from_scipy_sparse_matrix` (pyg-team#5736)

Added Type Hint support for the following: `transforms.SIGN`,
`utils.to_scipy_sparse_matrix` and `utils.from_scipy_sparse_matrix`

Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants