Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Type Hints] Missing type hints in transforms.* #5753

Merged
merged 5 commits into from
Oct 17, 2022
Merged

Conversation

EdisonLeeeee
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #5753 (80318e8) into master (c594c85) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 80318e8 differs from pull request most recent head 9b76686. Consider uploading reports for the commit 9b76686 to get more accurate results

@@           Coverage Diff           @@
##           master    #5753   +/-   ##
=======================================
  Coverage   83.97%   83.97%           
=======================================
  Files         349      349           
  Lines       19348    19350    +2     
=======================================
+ Hits        16248    16250    +2     
  Misses       3100     3100           
Impacted Files Coverage Δ
torch_geometric/transforms/add_self_loops.py 94.44% <100.00%> (ø)
torch_geometric/transforms/center.py 100.00% <100.00%> (ø)
torch_geometric/transforms/compose.py 93.33% <100.00%> (ø)
torch_geometric/transforms/delaunay.py 100.00% <100.00%> (ø)
torch_geometric/transforms/gcn_norm.py 44.44% <100.00%> (+3.26%) ⬆️
...orch_geometric/transforms/generate_mesh_normals.py 100.00% <100.00%> (ø)
...orch_geometric/transforms/linear_transformation.py 91.66% <100.00%> (ø)
torch_geometric/transforms/local_degree_profile.py 100.00% <100.00%> (ø)
torch_geometric/transforms/normalize_features.py 100.00% <100.00%> (ø)
torch_geometric/transforms/normalize_rotation.py 100.00% <100.00%> (ø)
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

CHANGELOG.md Outdated Show resolved Hide resolved
@rusty1s rusty1s enabled auto-merge (squash) October 17, 2022 17:02
@rusty1s rusty1s merged commit f97f26d into master Oct 17, 2022
@rusty1s rusty1s deleted the transforms_typehints branch October 17, 2022 17:05
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants