Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Type Hints] nn.dense_diff_pool #5754

Merged
merged 11 commits into from
Oct 18, 2022
Merged

[Type Hints] nn.dense_diff_pool #5754

merged 11 commits into from
Oct 18, 2022

Conversation

akash-vartak
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 17, 2022 •
edited
Loading

Codecov Report

Merging #5754 (9d7d5b7) into master (90ebe55) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9d7d5b7 differs from pull request most recent head ccd3836. Consider uploading reports for the commit ccd3836 to get more accurate results

@@           Coverage Diff           @@
##           master    #5754   +/-   ##
=======================================
  Coverage   83.97%   83.98%           
=======================================
  Files         349      349           
  Lines       19350    19352    +2     
=======================================
+ Hits        16250    16252    +2     
  Misses       3100     3100
Impacted Files Coverage Δ
torch_geometric/nn/dense/diff_pool.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s mentioned this pull request Oct 17, 2022
Closed
@wsad1 wsad1 merged commit 7a2c7b3 into pyg-team:master Oct 18, 2022
@akash-vartak akash-vartak deleted the pyg_dev_dense_diff_pool branch October 18, 2022 16:33
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
@akash-vartak @pre-commit-ci
@wsad1 @JakubPietrakIntel
[Type Hints] nn.dense_diff_pool (pyg-team#5754)
45d30ca 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsad1 wsad1 wsad1 approved these changes

Assignees

@akash-vartak akash-vartak

Labels
0 - Priority P0 nn type hints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akash-vartak @wsad1 @rusty1s