Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Type Hints] nn.AttentiveFP #5766

Merged
merged 5 commits into from
Oct 18, 2022
Merged

[Type Hints] nn.AttentiveFP #5766

merged 5 commits into from
Oct 18, 2022

Conversation

TanveshT
Copy link
Contributor

Changes

  • added missing type hints to GATEConv & AttentiveFP

@codecov
Copy link

codecov bot commented Oct 18, 2022 •
edited
Loading

Codecov Report

Merging #5766 (f1df0e9) into master (a56311a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head f1df0e9 differs from pull request most recent head 61824a4. Consider uploading reports for the commit 61824a4 to get more accurate results

@@            Coverage Diff             @@
##           master    #5766      +/-   ##
==========================================
+ Coverage   83.97%   83.98%   +0.01%     
==========================================
  Files         349      349              
  Lines       19403    19369      -34     
==========================================
- Hits        16293    16267      -26     
+ Misses       3110     3102       -8
Impacted Files Coverage Δ
torch_geometric/nn/models/attentive_fp.py 21.68% <100.00%> (ø)
torch_geometric/transforms/gdc.py 78.50% <0.00%> (-1.00%) ⬇️
torch_geometric/nn/dense/diff_pool.py 100.00% <0.00%> (ø)
torch_geometric/utils/undirected.py 91.66% <0.00%> (+10.03%) ⬆️
torch_geometric/utils/sort_edge_index.py 100.00% <0.00%> (+12.50%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s mentioned this pull request Oct 18, 2022
Closed
rusty1s
rusty1s approved these changes Oct 18, 2022
View reviewed changes
torch_geometric/nn/models/attentive_fp.py Outdated Show resolved Hide resolved
@rusty1s rusty1s enabled auto-merge (squash) October 18, 2022 16:51
@rusty1s rusty1s merged commit d8a8004 into pyg-team:master Oct 18, 2022
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
@TanveshT @rusty1s @JakubPietrakIntel
[Type Hints] nn.AttentiveFP (pyg-team#5766)
f88b1b9 
## Changes

- added missing type hints to `GATEConv` & `AttentiveFP`

Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

Assignees

@TanveshT TanveshT

Labels
0 - Priority P0 nn type hints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TanveshT @rusty1s