Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose disjoint sampling option to NeighborLoader and LinkNeighborLoader #5775

Merged
merged 3 commits into from
Oct 20, 2022
Merged

Expose disjoint sampling option to NeighborLoader and LinkNeighborLoader #5775

merged 3 commits into from
Oct 20, 2022

Conversation

egressybeni
Copy link
Contributor

see discussion: #5660

@egressybeni egressybeni changed the title exposed disjoint sampling to NeighborhoodLoader exposing disjoint sampling to NeighborhoodLoader Oct 19, 2022
rusty1s
rusty1s approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@rusty1s rusty1s changed the title exposing disjoint sampling to NeighborhoodLoader Expose disjoint sampling option to NeighborLoader and LinkNeighborLoader Oct 20, 2022
@rusty1s rusty1s enabled auto-merge (squash) October 20, 2022 07:39
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #5775 (8b0918e) into master (bd41b16) will decrease coverage by 1.87%.
The diff coverage is 85.71%.

❗ Current head 8b0918e differs from pull request most recent head 970207c. Consider uploading reports for the commit 970207c to get more accurate results

@@            Coverage Diff             @@
##           master    #5775      +/-   ##
==========================================
- Coverage   85.83%   83.96%   -1.88%     
==========================================
  Files         349      349              
  Lines       19424    19423       -1     
==========================================
- Hits        16673    16308     -365     
- Misses       2751     3115     +364
Impacted Files Coverage Δ
torch_geometric/loader/link_neighbor_loader.py 100.00% <ø> (ø)
torch_geometric/sampler/neighbor_sampler.py 77.41% <85.71%> (+0.49%) ⬆️
torch_geometric/nn/models/dimenet_utils.py 0.00% <0.00%> (-75.52%) ⬇️
torch_geometric/nn/models/dimenet.py 14.51% <0.00%> (-53.00%) ⬇️
torch_geometric/profile/profile.py 37.89% <0.00%> (-26.32%) ⬇️
torch_geometric/nn/conv/utils/typing.py 81.25% <0.00%> (-17.50%) ⬇️
torch_geometric/nn/pool/asap.py 92.10% <0.00%> (-7.90%) ⬇️
torch_geometric/nn/inits.py 67.85% <0.00%> (-7.15%) ⬇️
torch_geometric/transforms/add_self_loops.py 94.44% <0.00%> (-5.56%) ⬇️
torch_geometric/nn/resolver.py 88.88% <0.00%> (-5.56%) ⬇️
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s merged commit f4a485f into pyg-team:master Oct 20, 2022
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
@egressybeni @rusty1s @JakubPietrakIntel
Expose disjoint sampling option to NeighborLoader and `LinkNeighb…
6a98f56 
…orLoader` (pyg-team#5775)

see discussion:
pyg-team#5660

Co-authored-by: Be%CC%81ni Balazs Egressy Beni.Balazs.Egressy@ibm.com <begressy@cccxl011.pok.ibm.com>
Co-authored-by: rusty1s <matthias.fey@tu-dortmund.de>
@egressybeni egressybeni deleted the disjoint_neighbor_loader branch September 8, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

Assignees

@egressybeni egressybeni

Labels
0 - Priority P0 feature loader
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egressybeni @rusty1s