Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Type Hints] nn.DimeNet #5806

Merged
merged 6 commits into from
Oct 24, 2022
Merged

[Type Hints] nn.DimeNet #5806

merged 6 commits into from
Oct 24, 2022

Conversation

intellist
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 23, 2022 •
edited
Loading

Codecov Report

Merging #5806 (ae2d1fa) into master (892b4bb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head ae2d1fa differs from pull request most recent head 0b6b5a0. Consider uploading reports for the commit 0b6b5a0 to get more accurate results

@@           Coverage Diff           @@
##           master    #5806   +/-   ##
=======================================
  Coverage   83.97%   83.97%           
=======================================
  Files         349      349           
  Lines       19427    19429    +2     
=======================================
+ Hits        16313    16315    +2     
  Misses       3114     3114
Impacted Files Coverage Δ
torch_geometric/nn/models/dimenet.py 14.90% <100.00%> (+0.39%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s changed the title [Type Hints] nn.dimenet [Type Hints] nn.DimeNet Oct 24, 2022
@rusty1s rusty1s mentioned this pull request Oct 24, 2022
Closed
@rusty1s rusty1s enabled auto-merge (squash) October 24, 2022 06:46
@rusty1s rusty1s merged commit a292144 into pyg-team:master Oct 24, 2022
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
@intellist @pre-commit-ci
@rusty1s @JakubPietrakIntel
[Type Hints] nn.DimeNet (pyg-team#5806)
713bca6 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

Assignees

@intellist intellist

Labels
0 - Priority P0 nn type hints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@intellist @rusty1s