-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TorchScript support for AttentiveFP
#5868
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5868 +/- ##
==========================================
- Coverage 86.06% 84.05% -2.01%
==========================================
Files 349 349
Lines 19477 19482 +5
==========================================
- Hits 16762 16376 -386
- Misses 2715 3106 +391
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rusty1s
changed the title
add TorchScript support on AttentiveFP
Add TorchScript support for Nov 1, 2022
AttentiveFP
rusty1s
reviewed
Nov 1, 2022
rusty1s
approved these changes
Nov 4, 2022
JakubPietrakIntel
pushed a commit
to JakubPietrakIntel/pytorch_geometric
that referenced
this pull request
Nov 25, 2022
Add TorchScript JIT support on AttentiveFP. Now AttentiveFP can use the following code to directly get TorchScript model. `model = AttentiveFP(in_channels=..., jittable=True)` `jit = torch.jit.script(model)` To do this, we first add the propagate type in GATEConv and then reorganize the ModuleList logic to satisfy TorchScript language syntax. Co-authored-by: jxin <jxin@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: rusty1s <matthias.fey@tu-dortmund.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TorchScript JIT support on AttentiveFP.
Now AttentiveFP can use the following code to directly get TorchScript model.
model = AttentiveFP(in_channels=..., jittable=True)
jit = torch.jit.script(model)
To do this, we first add the propagate type in GATEConv and then reorganize the ModuleList logic to satisfy TorchScript language syntax.