-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable to set custom number of steps in benchmarks #5898
Conversation
kgajdamo
commented
Nov 4, 2022
- Added --num-steps argument, that allows to set number of the steps (batches two iterate over) in inference and training benchmarks.
- Added wrapper for NeighborLoader, that handles custom number of steps.
Codecov Report
@@ Coverage Diff @@
## master #5898 +/- ##
=======================================
Coverage 84.49% 84.49%
=======================================
Files 361 361
Lines 19840 19840
=======================================
Hits 16763 16763
Misses 3077 3077 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hi @kgajdamo , thanks for your hard work! For benchmark purpose, the function of setting |
@rusty1s please do not merge it yet. I noticed that for the same number of steps the version with RandomSampler is x4 faster. While the time should be the same. I haven't had time to look into it yet. |
1 similar comment
@rusty1s please do not merge it yet. I noticed that for the same number of steps the version with RandomSampler is x4 faster. While the time should be the same. I haven't had time to look into it yet. |
Ok :) |
@rusty1s I checked it and found out what was the reason off such timing. I provided wrong first argument to the RandomSampler:
But when I put instead of |
I think you need to use |
@rusty1s Thank You! Now it's working and You can merge. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
- Added --num-steps argument, that allows to set number of the steps (batches two iterate over) in inference and training benchmarks. - Added wrapper for NeighborLoader, that handles custom number of steps. Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>