-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nn.dense_mincut_pool
Add temperature parameter to mincut pool operator
#5908
Merged
rusty1s
merged 9 commits into
pyg-team:master
from
shhs29:add-temperature-parameter-to-mincut-pool
Nov 7, 2022
Merged
nn.dense_mincut_pool
Add temperature parameter to mincut pool operator
#5908
rusty1s
merged 9 commits into
pyg-team:master
from
shhs29:add-temperature-parameter-to-mincut-pool
Nov 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5908 +/- ##
==========================================
- Coverage 86.41% 84.44% -1.98%
==========================================
Files 349 349
Lines 19507 19502 -5
==========================================
- Hits 16857 16468 -389
- Misses 2650 3034 +384
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shhs29
changed the title
Nov 5, 2022
nn.dense_mincut_pool
Add temperature parameter to dense mincut pool operatornn.dense_mincut_pool
Add temperature parameter to mincut pool operator
EdisonLeeeee
reviewed
Nov 6, 2022
rusty1s
approved these changes
Nov 7, 2022
JakubPietrakIntel
pushed a commit
to JakubPietrakIntel/pytorch_geometric
that referenced
this pull request
Nov 25, 2022
…rator (pyg-team#5908) Hi, I have added the temp argument to ``dense_mincut_pool`` operator with a default value of 1.0. I have not modified the corresponding tests. Kindly let me know if you want me to add tests with the new temp argument. Thanks and Regards, Shweta Ann Jacob Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have added the temp argument to
dense_mincut_pool
operator with a default value of 1.0. I have not modified the corresponding tests. Kindly let me know if you want me to add tests with the new temp argument.Thanks and Regards,
Shweta Ann Jacob