Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nn.dense_mincut_pool Add temperature parameter to mincut pool operator #5908

Merged

Conversation

shhs29
Copy link
Contributor

@shhs29 shhs29 commented Nov 5, 2022

Hi,

I have added the temp argument to dense_mincut_pool operator with a default value of 1.0. I have not modified the corresponding tests. Kindly let me know if you want me to add tests with the new temp argument.

Thanks and Regards,
Shweta Ann Jacob

@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Merging #5908 (22f1d04) into master (418dbd4) will decrease coverage by 1.97%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5908      +/-   ##
==========================================
- Coverage   86.41%   84.44%   -1.98%     
==========================================
  Files         349      349              
  Lines       19507    19502       -5     
==========================================
- Hits        16857    16468     -389     
- Misses       2650     3034     +384     
Impacted Files Coverage Δ
torch_geometric/nn/dense/mincut_pool.py 100.00% <100.00%> (ø)
torch_geometric/nn/models/dimenet_utils.py 0.00% <0.00%> (-75.52%) ⬇️
torch_geometric/nn/models/dimenet.py 14.90% <0.00%> (-52.76%) ⬇️
torch_geometric/profile/profile.py 36.73% <0.00%> (-27.56%) ⬇️
torch_geometric/nn/conv/utils/typing.py 81.25% <0.00%> (-17.50%) ⬇️
torch_geometric/nn/pool/asap.py 92.10% <0.00%> (-7.90%) ⬇️
torch_geometric/nn/inits.py 67.85% <0.00%> (-7.15%) ⬇️
torch_geometric/nn/dense/linear.py 87.40% <0.00%> (-5.93%) ⬇️
torch_geometric/transforms/add_self_loops.py 94.44% <0.00%> (-5.56%) ⬇️
torch_geometric/nn/resolver.py 88.88% <0.00%> (-5.56%) ⬇️
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shhs29 shhs29 changed the title nn.dense_mincut_pool Add temperature parameter to dense mincut pool operator nn.dense_mincut_pool Add temperature parameter to mincut pool operator Nov 5, 2022
@shhs29 shhs29 marked this pull request as ready for review November 5, 2022 21:26
torch_geometric/nn/dense/mincut_pool.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
torch_geometric/nn/dense/mincut_pool.py Outdated Show resolved Hide resolved
@rusty1s rusty1s merged commit 6869275 into pyg-team:master Nov 7, 2022
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
…rator (pyg-team#5908)

Hi,

I have added the temp argument to ``dense_mincut_pool`` operator with a
default value of 1.0. I have not modified the corresponding tests.
Kindly let me know if you want me to add tests with the new temp
argument.

Thanks and Regards,
Shweta Ann Jacob

Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants