Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lr_scheduler_solver and customized lr_scheduler classes #5942

Merged
merged 19 commits into from
Nov 10, 2022

Conversation

lightaime
Copy link
Contributor

@lightaime lightaime commented Nov 9, 2022

Add lr_scheduler_solver and customized lr_scheduler classes to support getting any learning rate scheduler implemented in pyg and pytorch from its name. Maybe a better location than utils like torch_geometric.optim in case we develop specific optimization methods for GNNs?

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #5942 (6ee8f6f) into master (0625563) will decrease coverage by 0.12%.
The diff coverage is 78.78%.

❗ Current head 6ee8f6f differs from pull request most recent head 04f2dc6. Consider uploading reports for the commit 04f2dc6 to get more accurate results

@@            Coverage Diff             @@
##           master    #5942      +/-   ##
==========================================
- Coverage   84.51%   84.39%   -0.13%     
==========================================
  Files         359      352       -7     
  Lines       19738    19632     -106     
==========================================
- Hits        16682    16568     -114     
- Misses       3056     3064       +8     
Impacted Files Coverage Δ
torch_geometric/utils/lr_scheduler.py 78.78% <78.78%> (ø)
torch_geometric/utils/mixin.py 85.71% <0.00%> (-14.29%) ⬇️
torch_geometric/nn/fx.py 89.69% <0.00%> (-1.55%) ⬇️
torch_geometric/nn/__init__.py 100.00% <0.00%> (ø)
torch_geometric/nn/models/schnet.py 70.42% <0.00%> (ø)
torch_geometric/explain/explainer.py
torch_geometric/explain/__init__.py
torch_geometric/explain/algorithm/__init__.py
torch_geometric/explain/config.py
...rch_geometric/explain/algorithm/dummy_explainer.py
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added the nn label Nov 10, 2022
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@rusty1s rusty1s enabled auto-merge (squash) November 10, 2022 08:24
@rusty1s rusty1s merged commit 1f63bc4 into master Nov 10, 2022
@rusty1s rusty1s deleted the lr_scheduler_cls branch November 10, 2022 08:27
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
…team#5942)

Add `lr_scheduler_solver` and customized `lr_scheduler` classes to
support getting any learning rate scheduler implemented in pyg and
pytorch from its name. Maybe a better location than `utils` like
`torch_geometric.optim` in case we develop specific optimization methods
for GNNs?

Co-authored-by: Guohao Li <lighaime@gmail.com>
Co-authored-by: rusty1s <matthias.fey@tu-dortmund.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants