Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for int32 graphs in NeighborLoader #5948

Merged
merged 11 commits into from
Nov 14, 2022
Merged

Support for int32 graphs in NeighborLoader #5948

merged 11 commits into from
Nov 14, 2022

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Nov 10, 2022

No description provided.

@rusty1s rusty1s marked this pull request as draft November 10, 2022 12:59
@codecov
Copy link

codecov bot commented Nov 10, 2022 •
edited
Loading

Codecov Report

Merging #5948 (52ff11a) into master (ebde8e5) will increase coverage by 0.00%.
The diff coverage is 85.71%.

@@           Coverage Diff           @@
##           master    #5948   +/-   ##
=======================================
  Coverage   84.49%   84.49%           
=======================================
  Files         361      361           
  Lines       19839    19843    +4     
=======================================
+ Hits        16762    16766    +4     
  Misses       3077     3077
Impacted Files Coverage Δ
torch_geometric/loader/utils.py 83.23% <66.66%> (+0.09%) ⬆️
torch_geometric/sampler/neighbor_sampler.py 77.89% <100.00%> (+0.23%) ⬆️
torch_geometric/sampler/utils.py 86.15% <100.00%> (+0.21%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s self-assigned this Nov 10, 2022
@rusty1s rusty1s requested a review from ZenoTan November 10, 2022 13:23
@rusty1s rusty1s marked this pull request as ready for review November 10, 2022 13:24
@rusty1s
Copy link
Member Author

rusty1s commented Nov 10, 2022

@ZenoTan Please take a look :)

@ZenoTan
Copy link
Member

ZenoTan commented Nov 11, 2022

Also I guess this diff would also be good for every other integer types?

@rusty1s rusty1s merged commit 0b3f8e9 into master Nov 14, 2022
@rusty1s rusty1s deleted the int32 branch November 14, 2022 19:28
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 16, 2022
@rusty1s @JakubPietrakIntel
Support for int32 graphs in NeighborLoader (pyg-team#5948)
19b14f6
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
@rusty1s @JakubPietrakIntel
Support for int32 graphs in NeighborLoader (pyg-team#5948)
2028253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZenoTan ZenoTan ZenoTan approved these changes

Assignees

@rusty1s rusty1s

Labels
0 - Priority P0 feature loader
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rusty1s @ZenoTan