Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sampled_sub for faster utils.softmax #6155

Merged
merged 4 commits into from
Dec 6, 2022
Merged

Use sampled_sub for faster utils.softmax #6155

merged 4 commits into from
Dec 6, 2022

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Dec 6, 2022

Also refactors WITH_PYG_LIB within TorchScript modules.

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #6155 (074d0fe) into master (ced3034) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6155      +/-   ##
==========================================
- Coverage   84.35%   84.35%   -0.01%     
==========================================
  Files         365      365              
  Lines       20502    20500       -2     
==========================================
- Hits        17295    17293       -2     
  Misses       3207     3207              
Impacted Files Coverage Δ
torch_geometric/nn/conv/rgcn_conv.py 95.30% <100.00%> (-0.10%) ⬇️
torch_geometric/nn/dense/linear.py 87.21% <100.00%> (-0.19%) ⬇️
torch_geometric/nn/norm/layer_norm.py 100.00% <100.00%> (ø)
torch_geometric/sampler/neighbor_sampler.py 66.79% <100.00%> (-0.26%) ⬇️
torch_geometric/utils/softmax.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s merged commit 11e576b into master Dec 6, 2022
@rusty1s rusty1s deleted the faster_softmax branch December 6, 2022 11:31
@ZeynepP
Copy link
Contributor

ZeynepP commented Dec 6, 2022

Final qualifiers are available since Python 3.8. This makes the package not compatible anymore with python 3.7.

@rusty1s
Copy link
Member Author

rusty1s commented Dec 6, 2022

Thanks for letting me know. Will fix soon.

@rusty1s
Copy link
Member Author

rusty1s commented Dec 6, 2022

Fixed this via #6160. Sorry for the inconvenience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants