Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subgraph Visualization of GNN Explanations #6235

Merged
merged 16 commits into from
Dec 19, 2022

Conversation

akash-vartak
Copy link
Member

No description provided.

@akash-vartak akash-vartak requested a review from rusty1s December 13, 2022 21:19
@akash-vartak akash-vartak self-assigned this Dec 13, 2022
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #6235 (966c49d) into master (9fa50ef) will decrease coverage by 0.21%.
The diff coverage is 28.20%.

❗ Current head 966c49d differs from pull request most recent head 86259f4. Consider uploading reports for the commit 86259f4 to get more accurate results

@@            Coverage Diff             @@
##           master    #6235      +/-   ##
==========================================
- Coverage   84.54%   84.33%   -0.22%     
==========================================
  Files         377      378       +1     
  Lines       20936    21010      +74     
==========================================
+ Hits        17701    17719      +18     
- Misses       3235     3291      +56     
Impacted Files Coverage Δ
torch_geometric/visualization/graph.py 14.28% <14.28%> (ø)
torch_geometric/explain/explanation.py 96.84% <84.61%> (-1.99%) ⬇️
torch_geometric/visualization/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wsad1 wsad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. Left some comments.

@rusty1s rusty1s marked this pull request as ready for review December 19, 2022 10:10
@rusty1s
Copy link
Member

rusty1s commented Dec 19, 2022

Thank you! I moved the visualization code to torch_geometric.visualization to make it re-usable outside of explanations. Also added networkx backend support in case graphviz is not installed. Hope the changes are okay for you :)

@rusty1s rusty1s enabled auto-merge (squash) December 19, 2022 10:14
@rusty1s rusty1s merged commit 7a8ea61 into pyg-team:master Dec 19, 2022
@akash-vartak
Copy link
Member Author

Stating here for easy linking.
This is a PR for Issue #5631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants