Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Cycle Motif Support #6256

Merged
merged 5 commits into from
Dec 17, 2022
Merged

Conversation

shenoynikhil
Copy link
Contributor

@shenoynikhil shenoynikhil commented Dec 16, 2022

Support for cycle motif. Based on #6255

  • Adds cycle motif class
  • Adds test for cycle motif
  • Updated CHANGELOG
Doubt [Remove if cleared]

I have not added node classification labels (I guess these motifs don't have them)

@shenoynikhil shenoynikhil marked this pull request as ready for review December 16, 2022 20:36
@shenoynikhil shenoynikhil mentioned this pull request Dec 16, 2022
2 tasks
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #6256 (0d0ac96) into master (f622fee) will decrease coverage by 1.86%.
The diff coverage is n/a.

❗ Current head 0d0ac96 differs from pull request most recent head f490606. Consider uploading reports for the commit f490606 to get more accurate results

@@            Coverage Diff             @@
##           master    #6256      +/-   ##
==========================================
- Coverage   86.42%   84.55%   -1.87%     
==========================================
  Files         377      377              
  Lines       20974    20937      -37     
==========================================
- Hits        18126    17704     -422     
- Misses       2848     3233     +385     
Impacted Files Coverage Δ
torch_geometric/nn/models/dimenet_utils.py 0.00% <0.00%> (-75.52%) ⬇️
torch_geometric/nn/models/dimenet.py 14.90% <0.00%> (-52.76%) ⬇️
torch_geometric/profile/profile.py 33.33% <0.00%> (-25.39%) ⬇️
torch_geometric/nn/conv/utils/typing.py 83.75% <0.00%> (-15.00%) ⬇️
torch_geometric/nn/pool/asap.py 92.10% <0.00%> (-7.90%) ⬇️
torch_geometric/nn/inits.py 67.85% <0.00%> (-7.15%) ⬇️
torch_geometric/resolver.py 82.75% <0.00%> (-6.90%) ⬇️
torch_geometric/nn/dense/linear.py 85.40% <0.00%> (-5.91%) ⬇️
torch_geometric/transforms/add_self_loops.py 94.44% <0.00%> (-5.56%) ⬇️
torch_geometric/nn/models/attentive_fp.py 95.83% <0.00%> (-4.17%) ⬇️
... and 29 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wsad1 wsad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good mostly. Left some comments.

torch_geometric/datasets/motif_generator/cycle.py Outdated Show resolved Hide resolved
torch_geometric/datasets/motif_generator/cycle.py Outdated Show resolved Hide resolved
torch_geometric/datasets/motif_generator/cycle.py Outdated Show resolved Hide resolved
@rusty1s rusty1s enabled auto-merge (squash) December 17, 2022 12:10
@rusty1s rusty1s merged commit a864b18 into pyg-team:master Dec 17, 2022
rusty1s added a commit that referenced this pull request Dec 17, 2022
Part of #6255  (Builds on #6256)
Adds support for `BA2MotifDataset` from the paper [Parameterized
Explainer for Graph Neural Network](https://arxiv.org/abs/2011.04573).

- [x] Add the dataset and update init
- [x] Add tests
- [x] Update changelog

Co-authored-by: Nikhil Shenoy <shenoy@login02.sockeye.arc.ubc.ca>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
@shenoynikhil shenoynikhil deleted the shenoy/cycle-motifs branch December 17, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants