-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DDP NeighborLoader
examples
#6307
Conversation
Thank you! Can we replace the existing example with |
Yes, we could replace the existing pytorch_geometric/examples/multi_gpu/distributed_sampling.py. |
NeighborLoader
examples
Yes, since we want to fully replace |
Codecov Report
@@ Coverage Diff @@
## master #6307 +/- ##
=======================================
Coverage 84.59% 84.59%
=======================================
Files 381 381
Lines 21266 21266
=======================================
Hits 17990 17990
Misses 3276 3276 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
d067cbc
to
260a1c2
Compare
Thank you. I replaced the example and test epoch time, PyG2.2.0 spend half the epoch time than 2.1.0 so that I believe the code is correct. |
Since NeighborLoader is supported by pyg-lib. We could add an example in distributed_sampling_loader.py.
I refer #5340 (comment) to set
kwargs = {'batch_size': 1024, 'num_workers': 0}