-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a SAGEConv
model using the primitives in cugraph-ops
#6388
Conversation
@rusty1s This is now ready for review. Regarding the CI failure, should I disable the test for now as CI is cpu-only? The interface of cugraph-ops provides aggregation primitives specialized for both full graphs and bipartite graphs, with the latter being more performant. That is why you see the extra argument CC: @stadlmax |
Thanks. You can use the |
Codecov Report
@@ Coverage Diff @@
## master #6388 +/- ##
=======================================
Coverage 86.23% 86.24%
=======================================
Files 413 416 +3
Lines 22751 22769 +18
=======================================
+ Hits 19620 19636 +16
- Misses 3131 3133 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hey @tingyu66 Can you give me write access to the PR? |
Invited. |
@tingyu66 Thanks. I made a past. Can you confirm that everything runs through? I sadly still cannot test it :( |
Thank you for updating |
Super, then we are good to merge. Can we update the other modules to look similar? |
Sure. I will make changes accordingly. |
Shall we merge this in? Still need 1 approving review. |
This PR adds a GraphSAGE model
torch_geometric.nn.SAGEConvCuGraph
that leverages the optimized aggregation function in cugraph-ops, similar to #6278.Fixes rapidsai/cugraph-ops#178.