Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FastHGTConv to correctly call the value module #7050

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

toenshoff
Copy link
Contributor

This fixes a small bug in the new fast_hgt_conv layer, which incorrectly called the module self.k_rel instead of self.v_rel to generate the value vectors v.

Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

@rusty1s rusty1s changed the title Fix fast_hgt_conv Fix FastHGTConv to correctly call the value module Mar 27, 2023
@rusty1s rusty1s enabled auto-merge (squash) March 27, 2023 13:28
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #7050 (a4b7971) into master (0e439f3) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a4b7971 differs from pull request most recent head 825319e. Consider uploading reports for the commit 825319e to get more accurate results

@@           Coverage Diff           @@
##           master    #7050   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files         436      436           
  Lines       23837    23837           
=======================================
  Hits        21818    21818           
  Misses       2019     2019           
Impacted Files Coverage Δ
torch_geometric/nn/conv/fast_hgt_conv.py 96.35% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s merged commit 958e43b into pyg-team:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants