Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add torch_geometric.utils.lexsort #7775

Merged
merged 8 commits into from
Jul 19, 2023
Merged

Add torch_geometric.utils.lexsort #7775

merged 8 commits into from
Jul 19, 2023

Conversation

ebrahimpichka
Copy link
Contributor

resolves #7743
Added Pytorch implementation of numpy lexsort.

@ebrahimpichka ebrahimpichka requested review from mananshah99 and a team as code owners July 19, 2023 12:43
@rusty1s rusty1s requested a review from wsad1 as a code owner July 19, 2023 14:57
@rusty1s rusty1s changed the title Refactor numpy lexsort to torch_lexsort Add torch_geometric.utils.lexsort Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #7775 (bb687ba) into master (a90949d) will increase coverage by 0.04%.
The diff coverage is 87.50%.

❗ Current head bb687ba differs from pull request most recent head 33b291b. Consider uploading reports for the commit 33b291b to get more accurate results

@@            Coverage Diff             @@
##           master    #7775      +/-   ##
==========================================
+ Coverage   91.56%   91.60%   +0.04%     
==========================================
  Files         452      453       +1     
  Lines       25547    25541       -6     
==========================================
+ Hits        23392    23397       +5     
+ Misses       2155     2144      -11     
Impacted Files Coverage Δ
torch_geometric/utils/lexsort.py 81.25% <81.25%> (ø)
...h_geometric/contrib/explain/graphmask_explainer.py 90.34% <100.00%> (+4.27%) ⬆️
torch_geometric/nn/models/dimenet.py 99.67% <100.00%> (ø)
torch_geometric/sampler/utils.py 93.44% <100.00%> (-0.21%) ⬇️
torch_geometric/utils/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s merged commit 87ca719 into pyg-team:master Jul 19, 2023
@ebrahimpichka ebrahimpichka deleted the pt_lexsort branch July 19, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyTorch implementation of np.lexsort() in sort_csc util fucnction
2 participants