Database implementation
#8028
Merged
Database implementation
#8028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8028 +/- ##
==========================================
- Coverage 89.61% 88.36% -1.26%
==========================================
Files 462 466 +4
Lines 27016 27626 +610
==========================================
+ Hits 24210 24411 +201
- Misses 2806 3215 +409
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
is it ok for me to create a test with a real sqlite db for testing purposes? may i create a setup and teardown fixture? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is related to #7946 this is a rough draft to create an abstract base class as we integrate this into the dataset and dataloader in the future. the idea is to create this class and implement a sqlite version of it.