Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mask argument to dense_to_sparse #8117

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

filipekstrm
Copy link
Contributor

Added optional argument mask to dense_to_sparse so that it can correctly invert a call to to_dense_adj by returning the correct edge_index in case there are graphs with different number of nodes (and hence, the dense adjacency matrix contains some padding)

…se can return the same edge_index as inputted to to_dense_adj in case there are graphs with different number of nodes (and hence, the dense adj matrix contains some padding)
@filipekstrm filipekstrm requested a review from wsad1 as a code owner October 3, 2023 11:30
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #8117 (c8fca85) into master (4ac8696) will decrease coverage by 0.02%.
The diff coverage is 80.76%.

❗ Current head c8fca85 differs from pull request most recent head a492418. Consider uploading reports for the commit a492418 to get more accurate results

@@            Coverage Diff             @@
##           master    #8117      +/-   ##
==========================================
- Coverage   88.23%   88.22%   -0.02%     
==========================================
  Files         471      471              
  Lines       28227    28244      +17     
==========================================
+ Hits        24907    24919      +12     
- Misses       3320     3325       +5     
Files Coverage Δ
torch_geometric/utils/sparse.py 88.53% <80.76%> (-1.47%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s changed the title Added mask argument to dense_to_sparse Added mask argument to dense_to_sparse Oct 3, 2023
@rusty1s rusty1s enabled auto-merge (squash) October 3, 2023 18:31
@rusty1s rusty1s merged commit 51c50c2 into pyg-team:master Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants