-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DistNeighborSampler
for homo graphs [2/6]
#8209
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8209 +/- ##
==========================================
+ Coverage 87.17% 88.08% +0.91%
==========================================
Files 473 473
Lines 28757 28774 +17
==========================================
+ Hits 25068 25345 +277
+ Misses 3689 3429 -260
... and 6 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
780865e
to
1389328
Compare
5fe69fb
to
b7acc09
Compare
DistNeighborSampler
for homo graphsDistNeighborSampler
for homo graphs [2/6]
530b9c7
to
d4b25a3
Compare
for more information, see https://pre-commit.ci
@@ -119,7 +119,10 @@ def __init__( | |||
feature_store, graph_store = data | |||
|
|||
# Obtain graph metadata: | |||
node_attrs = feature_store.get_all_tensor_attrs() | |||
node_attrs = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rusty1s Thank you for the review :). One comment about these lines: they are common for both homo and hetero. In case of homo the attr.group_name will be None and therefore the condition isinstance(attr.group_name, NodeType)
will never be met and node_attrs will be always empty. I will open a new PR with the previous version.
Changes made:
This PR is based on the #8083, so both must be combined to pass the tests.
Other distributed PRs:
#8083
#8080
#8085