Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MessagePassing interface thread-safe #9001

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Make MessagePassing interface thread-safe #9001

merged 3 commits into from
Mar 1, 2024

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Mar 1, 2024

Fixes #8994

@rusty1s rusty1s self-assigned this Mar 1, 2024
@rusty1s rusty1s requested review from a team, wsad1 and EdisonLeeeee as code owners March 1, 2024 16:58
@rusty1s rusty1s mentioned this pull request Mar 1, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.26%. Comparing base (8d625c4) to head (0a1f522).

Files Patch % Lines
torch_geometric/nn/conv/message_passing.py 71.42% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9001      +/-   ##
==========================================
- Coverage   89.27%   89.26%   -0.01%     
==========================================
  Files         468      468              
  Lines       30011    30012       +1     
==========================================
- Hits        26791    26790       -1     
- Misses       3220     3222       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusty1s rusty1s merged commit 849ca0a into master Mar 1, 2024
15 checks passed
@rusty1s rusty1s deleted the message_passing_thread_safe branch March 1, 2024 18:24
@jychoi-hpc jychoi-hpc mentioned this pull request Mar 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsad1 wsad1 Awaiting requested review from wsad1 wsad1 is a code owner

@EdisonLeeeee EdisonLeeeee Awaiting requested review from EdisonLeeeee EdisonLeeeee is a code owner

Assignees

@rusty1s rusty1s

Labels
0 - Priority P0 benchmark bug nn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible overwriting scenario with Jinja
1 participant
@rusty1s