fixing edge mask for directed graphs in k_hop_subgraph #9756
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example use case:
This gives the following result:
Expected Outcome:
Actual Outcome:
This stems from the fact that the line
torch.index_select(node_mask, 0, row, out=edge_mask)
overwritesedge_mask
, effectively only marking the edges used in the final hop asTrue
.To fix this, I have added
preserved_edge_mask
that will mark the edges used in each hop asTrue
.