Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update euler-angles.ipynb #417

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Dec 17, 2021

Fixes #416, and some typos

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #417 (e712ea9) into master (e63f856) will decrease coverage by 5.51%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
- Coverage   71.37%   65.85%   -5.52%     
==========================================
  Files          73       73              
  Lines        9459     9000     -459     
  Branches     1211     1209       -2     
==========================================
- Hits         6751     5927     -824     
- Misses       2538     2897     +359     
- Partials      170      176       +6     
Impacted Files Coverage Δ
clifford/test/test_algebra_initialisation.py 29.72% <0.00%> (-70.28%) ⬇️
clifford/taylor_expansions.py 26.86% <0.00%> (-70.15%) ⬇️
clifford/_numba_utils.py 38.46% <0.00%> (-42.68%) ⬇️
clifford/_layout.py 70.76% <0.00%> (-26.19%) ⬇️
clifford/_bit_helpers.py 71.42% <0.00%> (-21.68%) ⬇️
clifford/_settings.py 60.00% <0.00%> (-20.00%) ⬇️
clifford/caching.py 0.00% <0.00%> (-16.67%) ⬇️
clifford/tools/g3c/cuda_products.py 34.47% <0.00%> (-16.55%) ⬇️
clifford/__init__.py 69.23% <0.00%> (-16.40%) ⬇️
clifford/test/test_numba_extensions.py 83.66% <0.00%> (-16.34%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e63f856...e712ea9. Read the comment docs.

@arsenovic
Copy link
Member

thanks for fixing this eric!

@eric-wieser
Copy link
Member Author

eric-wieser commented Dec 17, 2021

Looks like I didn't actually commit the fix, only the test...

@eric-wieser eric-wieser force-pushed the eric-wieser/fix-euler-notebook branch from 8a4f028 to e712ea9 Compare January 12, 2022 19:40
@eric-wieser eric-wieser merged commit 3d7920e into master Jan 13, 2022
@zevisert zevisert mentioned this pull request Feb 3, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected numerical result, large difference between matrix and clifford method
2 participants