Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on latest sympy #489

Closed
moble opened this issue Aug 15, 2023 · 1 comment
Closed

Run tests on latest sympy #489

moble opened this issue Aug 15, 2023 · 1 comment
Milestone

Comments

@moble
Copy link
Member

moble commented Aug 15, 2023

As mentioned here the tests currently run on sympy 1.7; as of this writing, the current sympy version is 1.12, and the tests fail on it. When I removed the restriction to 1.7, I got a lot of failures that I'm guessing are related to sympy just organizing negative signs differently than it used to. This means that explicit comparisons to old results (as are done with nbval and in test_test.py) can fail spuriously. I suppose the thing to do would be to

  1. check more carefully than I have that most of those errors are indeed just sign-organization errors,
  2. re-run the notebooks to update their outputs, and
  3. update test_test.py to update its expected output.
@utensil
Copy link
Member

utensil commented Mar 28, 2024

Addressed by #493 .

@utensil utensil closed this as completed Mar 28, 2024
@utensil utensil added this to the 0.5.1 milestone Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants