Add github actions CI #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Aug 11, 2023
eric-wieser
reviewed
Aug 11, 2023
eric-wieser
reviewed
Aug 11, 2023
eric-wieser
reviewed
Aug 11, 2023
* Streamline matrix to avoid old special cases * Skip archiving flake8 output, because it is now in stdout * Skip archiving pytest output, because it appears in stdout * Temporarily run on pushes to any branch
|
Okay, I believe I've addressed the comments above. The tests passed here. |
eric-wieser
reviewed
Aug 14, 2023
|
Why is the doc build failed? Other than this and the need to resolve the conflict, all LGTM. |
utensil
reviewed
Aug 15, 2023
Looks like we were one of the lucky few to hit a brownout requiring the new .readthedocs.yaml format. I'll try to update it. |
`pip` is now only on the user path, not the system path
|
As everything looks good to me, and I wish to polish CI and bump Python etc. Merging this as the foundation. Thanks! |
Closed
utensil
added
the
state: needs changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to replicate the CircleCI workflow (which is not working as of this writing) in github actions. It also removes references to CircleCI.
It also fixes a few minor things I needed to do to get the tests to pass:
getargspecwithgetfullargspecingalgebra/lt.pyself.nargs = 0in the branch following thegetargspecusage, so that it's not referring to a non-existent variableifstatement ingalgebra/mv.pyso the linter doesn't chokepython_requiressyntax insetup.pyThis is one half of the split version of #486. The other half is a branch on my fork https://github.com/moble/galgebra/tree/jupyterlite, which starts relative to this PR's first commit; I'll make it into a PR once this is merged.