Avoid checking whether the basis blades are blades #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-picked from @meuns' branch.
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
==========================================
- Coverage 72.74% 72.71% -0.03%
==========================================
Files 11 11
Lines 4472 4472
==========================================
- Hits 3253 3252 -1
- Misses 1219 1220 +1
Continue to review full report at Codecov.
|
utensil
approved these changes
May 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from @meuns' branch (#68)
We can skip a check here, since we know
Ga.mv_bladeswill contain only blades.No behavior change, but likely a small performance boost.