Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Android build configuration #2249

Merged
merged 3 commits into from
Jun 14, 2023
Merged

Fix Android build configuration #2249

merged 3 commits into from
Jun 14, 2023

Conversation

cbdj
Copy link
Contributor

@cbdj cbdj commented Jun 13, 2023

Tested with buildozer with a custom recipe

@cbdj cbdj requested a review from a team as a code owner June 13, 2023 21:04
cbdj added a commit to cbdj/python-for-android that referenced this pull request Jun 13, 2023
@cbdj
Adding recipe for pygame-ce
01a7042 
Tested with buildozer and pygame-ce + pygame-community/pygame-ce#2249
@cbdj cbdj mentioned this pull request Jun 13, 2023
Open
Starbuck5
Starbuck5 approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! These changes make sense.

MightyJosip
MightyJosip approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@MightyJosip MightyJosip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for making this. Maybe in future we should standardize buildconfig process with addition of new files, but right now this should work 👍

@MightyJosip MightyJosip added this to the 2.3 milestone Jun 14, 2023
@MightyJosip MightyJosip merged commit 74191c3 into pygame-community:main Jun 14, 2023
@MightyJosip MightyJosip changed the title Fixing android build Fix Android build configuration Jun 14, 2023
@yolowex
Copy link
Contributor

yolowex commented Jun 15, 2023

tysm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starbuck5 Starbuck5 Starbuck5 approved these changes

@MightyJosip MightyJosip MightyJosip approved these changes

Assignees
No one assigned
Labels
Android buildconfig
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
5 participants
@cbdj @yolowex @MightyJosip @Starbuck5 @yunline