-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More efficient Buffer and Texture updates #508
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almarklein
force-pushed
the
buf-tex-updates
branch
from
April 18, 2023 14:53
85f3d8e
to
111868c
Compare
About done. Two validation examples fail. Will look into that, but otherwise this is good for review. |
Korijn
reviewed
Apr 19, 2023
Korijn
approved these changes
Apr 19, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #321
Todo
How it now works
(also added this to the code in a comment).
and its _wgpu_flags is unset.
in the logic that creates a pipeline object (e.g. in _pipeline.py), which
sets the appropriate usage flags (because that code knows how the resource
is used) and then uses ensure_wgpu_object to create the object.
but only go into it when they have their _wgpu_object set (i.e. when
the resource actually exists on the GPU).
and calls update_resource on each.
This PR basically makes the above work, and then removes the old system (which required updates more spread out over the code).