Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve reliability of lando tests #244

Closed
fubarhouse opened this issue Aug 2, 2020 · 2 comments
Closed

Improve reliability of lando tests #244

fubarhouse opened this issue Aug 2, 2020 · 2 comments

Comments

@fubarhouse
Copy link
Collaborator

At the moment Lando tests are a little flakey as part of the lando start section.
We should improve this for test reliability.
@fubarhouse fubarhouse changed the title Imrpove reliability of lando tests Improve reliability of lando tests Aug 2, 2020
@fubarhouse
Copy link
Collaborator Author

Needs more work.
https://travis-ci.com/github/fubarhouse/pygmy-go/jobs/368595849

@fubarhouse
Copy link
Collaborator Author

Current thought is to ignore errors for that line...
The failing container is the cli container and the service does in fact run and is tested afterwards.

Alternatively, tests could exclude the cli container.
Given this is not a fully released feature of lando support, this can be considered good enough at this time and it can be revisited later.

fubarhouse added a commit that referenced this issue Aug 19, 2020
@fubarhouse
#244: Stabilise Lando tests (#249)
fa5a103 
* Try rebuilding Lando project before starting.
* add sleep command to alndo build process
* ignore lando start failures
fubarhouse added a commit that referenced this issue Aug 19, 2020
@fubarhouse
#244: Stabilise Lando tests (#249)
dbfb1e0 
* Try rebuilding Lando project before starting.
* add sleep command to alndo build process
* ignore lando start failures
fubarhouse added a commit that referenced this issue Aug 19, 2020
@fubarhouse @dependabot-preview
#232: Update all restart policies to 'unless-stopped' (#250)
01a5e1a 
* #232: Update all restart policies to 'unless-stopped'

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>

* #233: Lando test (#234)

* Add a lando test
* Remove lando init from test
* update directory path change
* Update URL for lando project
* Lando uses slightly different Lagoon headers...

* Additional running check for container state searches. (#237)

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>

* Refactoring the `model` package (#239)

* Moar tests.
* Separate out Docker functions from the model package
* gofmt
* gofmt
* remove key operation examples for now
* Forgot to actually start the containers.
* Additional running check for container state searches. (#237)
* add dist to gitignore
* Update output path
* Decouple regression tests from using docker client api directly and use docker lib
* Add some notes on local development
* add service tests into travis

* Bump github.com/imdario/mergo from 0.3.9 to 0.3.10 (#240)

Bumps [github.com/imdario/mergo](https://github.com/imdario/mergo) from 0.3.9 to 0.3.10.
- [Release notes](https://github.com/imdario/mergo/releases)
- [Commits](darccio/mergo@v0.3.9...v0.3.10)

* Revert "Bump github.com/imdario/mergo from 0.3.9 to 0.3.10 (#240)" (#242)

This reverts commit c4ff1d3.

* Update applicable references from master to main

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>

* Bump github.com/spf13/viper from 1.7.0 to 1.7.1 (#245)

Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/spf13/viper/releases)
- [Commits](spf13/viper@v1.7.0...v1.7.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* #246: Create new value for services before merging default values in place (#247)

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>

* #244: Stabilise Lando tests (#249)

* Try rebuilding Lando project before starting.
* add sleep command to alndo build process
* ignore lando start failures

* Bump github.com/imdario/mergo from 0.3.9 to 0.3.11 (#248)

Bumps [github.com/imdario/mergo](https://github.com/imdario/mergo) from 0.3.9 to 0.3.11.
- [Release notes](https://github.com/imdario/mergo/releases)
- [Commits](darccio/mergo@v0.3.9...v0.3.11)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Update tests for field values of restart policy to match new value "unless-stopped"

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
fubarhouse added a commit that referenced this issue Aug 25, 2020
@fubarhouse
#244: Stabilise Lando tests (#249)
8f9e106 
* Try rebuilding Lando project before starting.
* add sleep command to alndo build process
* ignore lando start failures
fubarhouse added a commit that referenced this issue Aug 25, 2020
@fubarhouse @dependabot-preview
#232: Update all restart policies to 'unless-stopped' (#250)
a6881fe 
* #232: Update all restart policies to 'unless-stopped'

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>

* #233: Lando test (#234)

* Add a lando test
* Remove lando init from test
* update directory path change
* Update URL for lando project
* Lando uses slightly different Lagoon headers...

* Additional running check for container state searches. (#237)

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>

* Refactoring the `model` package (#239)

* Moar tests.
* Separate out Docker functions from the model package
* gofmt
* gofmt
* remove key operation examples for now
* Forgot to actually start the containers.
* Additional running check for container state searches. (#237)
* add dist to gitignore
* Update output path
* Decouple regression tests from using docker client api directly and use docker lib
* Add some notes on local development
* add service tests into travis

* Bump github.com/imdario/mergo from 0.3.9 to 0.3.10 (#240)

Bumps [github.com/imdario/mergo](https://github.com/imdario/mergo) from 0.3.9 to 0.3.10.
- [Release notes](https://github.com/imdario/mergo/releases)
- [Commits](darccio/mergo@v0.3.9...v0.3.10)

* Revert "Bump github.com/imdario/mergo from 0.3.9 to 0.3.10 (#240)" (#242)

This reverts commit c4ff1d3.

* Update applicable references from master to main

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>

* Bump github.com/spf13/viper from 1.7.0 to 1.7.1 (#245)

Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/spf13/viper/releases)
- [Commits](spf13/viper@v1.7.0...v1.7.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* #246: Create new value for services before merging default values in place (#247)

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>

* #244: Stabilise Lando tests (#249)

* Try rebuilding Lando project before starting.
* add sleep command to alndo build process
* ignore lando start failures

* Bump github.com/imdario/mergo from 0.3.9 to 0.3.11 (#248)

Bumps [github.com/imdario/mergo](https://github.com/imdario/mergo) from 0.3.9 to 0.3.11.
- [Release notes](https://github.com/imdario/mergo/releases)
- [Commits](darccio/mergo@v0.3.9...v0.3.11)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Update tests for field values of restart policy to match new value "unless-stopped"

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fubarhouse