Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner output on Windows #296

Closed
fubarhouse opened this issue Feb 9, 2021 · 0 comments · Fixed by #299
Closed

Cleaner output on Windows #296

fubarhouse opened this issue Feb 9, 2021 · 0 comments · Fixed by #299

Comments

@fubarhouse
Copy link
Collaborator

fubarhouse commented Feb 9, 2021

The reason colored output was removed was to have clean output on Windows.

Given a stakeholder has reversed this decision, coloured output should at the very least have a workaround on Windows.

So, I propose to centralize the calling to Aurora to a very small subpackage/folder which provides files which implement this behavior in Windows and non-Windows systems. That way, everybody can have the best of all worlds - and perhaps even the Windows build file could even include Windows support for colour - for example see the following...

https://github.com/logrusorgru/aurora/issues/2#issuecomment-299014211
fubarhouse added a commit that referenced this issue Feb 10, 2021
Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>
fubarhouse added a commit that referenced this issue Feb 12, 2021
* Initial commit for #296
* Add new line char
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant