Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with other gi-stub package #10

Closed
lovetox opened this issue Dec 31, 2021 · 7 comments
Closed

Merge with other gi-stub package #10

lovetox opened this issue Dec 31, 2021 · 7 comments

Comments

@lovetox
Copy link
Collaborator

lovetox commented Dec 31, 2021

Hi,

we developed our own gi-stub package here https://dev.gajim.org/gajim/gi-stubs

Because we want to offer it to everybody, and hope people contribute to it, we would like to ask if there is interest to merge it into this official project.

Main benefits are:

  • All functions available
  • Classes have all the methods
  • Some methods are already typed though only the most common
  • All the contstants and GEnums / GFlags are completely typed
  • More gi libs (Soup, Gst, GSound, ... )

Whats missing:

  • Base classes need to be added to the classes
  • method args are not typed
  • Think about using more elaborate concepts like Generic Types etc
@MrinmoyHaloi
Copy link
Contributor

Looks great. I wonder why pygobject devlopers haven't merged it yet. Atleast make the current stubs better

@lazka
Copy link
Member

lazka commented Jan 3, 2022

@lovetox I gave you maintainer rights here.

@lazka
Copy link
Member

lazka commented Jan 3, 2022

One thing I never found a good answer for was what to do with Gtk3 vs Gtk4 for example. Except adjust pygobject to allow versioned imports like from gi.repository import Gtk_3_0 as Gtk or something.

And in theory stubs can be auto generated.. but that's a long way out...

@lovetox
Copy link
Collaborator Author

lovetox commented Jan 3, 2022

Thanks @lazka i merged it.

for the Gtk3 / 4 discussion i would open a new issue as it would be offtopic here, maybe other people have also ideas

@lovetox lovetox closed this as completed Jan 3, 2022
@lazka
Copy link
Member

lazka commented Jan 3, 2022

ok, let me know when I should push to pypi, or if you want to be added there as well.

@lovetox
Copy link
Collaborator Author

lovetox commented Jan 3, 2022

I am not very experienced with pypi so would be great if you could keep doing that.
i think it makes sense to just push a new version as soon as possible.

is there a preferred way how to reach you? mail? gitter?

if you push a new version, i noticed that your mail address in setup.py has a typo

@lazka
Copy link
Member

lazka commented Jan 3, 2022

I am not very experienced with pypi so would be great if you could keep doing that. i think it makes sense to just push a new version as soon as possible.

OK

is there a preferred way how to reach you? mail? gitter?

Whatever you prefer. github is fine too.

if you push a new version, i noticed that your mail address in setup.py has a typo

thanks, fixed

CharlieQLe pushed a commit to CharlieQLe/pygobject-stubs that referenced this issue Dec 19, 2022
# This is the 1st commit message:

other: Reformat codebase with black

# This is the commit message #2:

Add Adw

# This is the commit message #3:

Add types for functions

# This is the commit message pygobject#4:

Add types for ActionRow

# This is the commit message pygobject#5:

Add types for Adw.Animation

# This is the commit message pygobject#6:

Add types for Adw.Application

# This is the commit message pygobject#7:

Add types for Adw.ApplicationWindow

# This is the commit message pygobject#8:

Update Gdk to 4.0

# This is the commit message pygobject#9:

Move Gdk into correct location

# This is the commit message pygobject#10:

Add types for Adw.Avatar

# This is the commit message pygobject#11:

Add types for Adw

# This is the commit message pygobject#12:

Removed Typing import

# This is the commit message pygobject#13:

Add types for Adw
CharlieQLe added a commit to CharlieQLe/pygobject-stubs that referenced this issue Dec 19, 2022
# This is the 1st commit message:

other: Reformat codebase with black

# This is the commit message #2:

Add Adw

# This is the commit message #3:

Add types for functions

# This is the commit message pygobject#4:

Add types for ActionRow

# This is the commit message pygobject#5:

Add types for Adw.Animation

# This is the commit message pygobject#6:

Add types for Adw.Application

# This is the commit message pygobject#7:

Add types for Adw.ApplicationWindow

# This is the commit message pygobject#8:

Update Gdk to 4.0

# This is the commit message pygobject#9:

Move Gdk into correct location

# This is the commit message pygobject#10:

Add types for Adw.Avatar

# This is the commit message pygobject#11:

Add types for Adw

# This is the commit message pygobject#12:

Removed Typing import

# This is the commit message pygobject#13:

Add types for Adw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants