Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the typo of attribute name decision_score_ #80

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Fix the typo of attribute name decision_score_ #80

merged 1 commit into from
Jul 26, 2023

Conversation

OldPanda
Copy link
Contributor

The argument should be decision_score_ other than decision_scores_ in a model object according to the definition of class Detector

@OldPanda OldPanda mentioned this pull request Jul 25, 2023
Closed
@coveralls
Copy link

coveralls commented Jul 26, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5652650448

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.562%
Totals Coverage Status
Change from base Build 5595818306: 0.0%
Covered Lines: 2503
Relevant Lines: 2514
💛 - Coveralls

kayzliu
kayzliu approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@kayzliu kayzliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. LGTM.

@kayzliu kayzliu merged commit 8d9a4c1 into pygod-team:main Jul 26, 2023
@OldPanda OldPanda deleted the fix-typo branch July 26, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayzliu kayzliu kayzliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OldPanda @coveralls @kayzliu