-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Contributing Guide #561
Update Contributing Guide #561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Κάποια μικρά suggestions αφησα μόνο!
Co-authored-by: Theofanis Petkos <thepetk@gmail.com>
Co-authored-by: Theofanis Petkos <thepetk@gmail.com>
Co-authored-by: Theofanis Petkos <thepetk@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Σωστή αυτή η παρατήρηση @gzisopoulos . Για αυτό πρέπει να γίνει default branch μας το 3.12 αφού γίνει merge με το master. |
Επισης το |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Πολύ καλές αλλαγές! Kudos to everyone 🎉
Co-authored-by: George Margaritis <gmargaritis@protonmail.com>
Co-authored-by: George Margaritis <gmargaritis@protonmail.com>
Co-authored-by: George Margaritis <gmargaritis@protonmail.com>
Co-authored-by: George Margaritis <gmargaritis@protonmail.com>
Co-authored-by: George Margaritis <gmargaritis@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skpanagiotis and everyone, amazing work! Thanks a lot for doing this!
A couple of comments (here and inline):
Can we add a second command to the 4th step of setting up. After git remote add upstream
, it'd be best if contributors also did git remote set-url --push upstream git@github.com:<your-username>/cpython.git
to avoid accidentally pushing to the upstream repo.
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Πρόσθεσα και το extra βήμα του @lysnikolaou |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks everyone!
Pushed the nitty comment I made above, I think we're good to merge at this point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving so that the button turns green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving so that the button turns green.
Ποιο issue κλείνει το συγκεκριμένο PR;
Closes #548
Περιγραφή του PR
Βελτίωση του Contributing Guide για να είναι πιο κατανοητός ο τρόπος που γίνεται συνεισφορά στο έργο της μετάφρασης.