-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Set track_progress=True by default #66
Conversation
This reverts commit 11ce691.
Guard against 'fatal: detected dubious ownership in repository'
git config --global --add safe.directory /__w/pyhf-tutorial/pyhf-tutorial | ||
git grep --name-only "track_progress=True" book | xargs sed --in-place 's/track_progress=True/track_progress=False/g' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this doesn't do anything for the Makefile
so that might not be ideal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked about this in https://github.com/orgs/executablebooks/discussions/1067.
In the notebooks set
track_progress=True
so that when users run interactively or locally they get information on pseudo-experiments. However, to avoid having huge JupyterBook output (track_progress=True
shows iterative updates of the progress bar in the JupyterBook output) have the CI switch this totrack_progress=False
during the build.