-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate inventory file (#662) #1182
base: 3.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great so far, thank you @simonhammes!
I think long term pyinfra should be moving towards inventory functions as the default to avoid the weird "list or tuple" thing for hosts/groups.
There's also potential for a DSL kind of inventory, but that's a future problem :)
7ac7e27
to
d4c424a
Compare
🙏
That seems like a wise decision imho. EDIT: I'll also add some tests. |
Let's just update the docs, would rather not increase complexity of the current situation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks great so far, tests would tie this up nicely!
d4c424a
to
e13a4b6
Compare
Thanks for the feedback, I have updated the docs.
Thank you! I agree, I'll add some tests. |
e13a4b6
to
b7a33ef
Compare
Let me know if you had something else in mind re: tests 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not know where to put this - maybe into deploy/inventories
?
No description provided.