hooks: add hook for jieba #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, the pull request is good but I'm rather uncomfortable with the library itself. I just opened up a file randomly to see what it does with its data files and I see this accessing data files from the wrong place, this trying to install a package on the fly into potentially the wrong Python environment (which wouldn't work with PyInstaller even if you did get the right environment) and a version comparison which will break when I'm happy to accept the pull request but I want you to be aware that I'm more likely to just mark the test as skipped and ignore this library than fix it at the first sign of |
|
The issue of installing There have been no updates for the library for several years, and I don't think they would have the time to review PRs even if I submit a fix. So, shall I just remove the test? |
|
If they're not publishing releases then that test will probably never run again (at least not automatically) so it doesn't make much difference whether or not it stays. @rokm What do you reckon? I say we just merge as is? |
|
Yes, let's merge as-is. We'll deal with any trouble rising from updates if/when they actually happen. |
github-actions bot
pushed a commit
to wxx9248/Pickle-Rush
that referenced
this pull request
Aug 30, 2023
…3.8 (#66) Bumps [pyinstaller-hooks-contrib](https://github.com/pyinstaller/pyinstaller-hooks-contrib) from 2023.7 to 2023.8. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/releases">pyinstaller-hooks-contrib's releases</a>.</em></p> <blockquote> <h2>2023.8</h2> <p>Please see the <a href="https://www.github.com/pyinstaller/pyinstaller-hooks-contrib/tree/master/CHANGELOG.rst">changelog</a> for more details</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/blob/master/CHANGELOG.rst">pyinstaller-hooks-contrib's changelog</a>.</em></p> <blockquote> <h2>2023.8 (2023-08-29)</h2> <p>New hooks</p> <pre><code> * Add hook for ``eng_to_ipa``. (`[#631](pyinstaller/pyinstaller-hooks-contrib#631) <https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/631>`_) * Add hook for ``jieba``. (`[#628](pyinstaller/pyinstaller-hooks-contrib#628) <https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/628>`_) * Add hook for ``khmer-nltk``. (`[#633](pyinstaller/pyinstaller-hooks-contrib#633) <https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/633>`_) * Add hook for ``Lingua``. (`[#626](pyinstaller/pyinstaller-hooks-contrib#626) <https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/626>`_) * Add hook for ``opencc-python``. (`[#627](pyinstaller/pyinstaller-hooks-contrib#627) <https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/627>`_) * Add hook for ``pymorphy3``. (`[#634](pyinstaller/pyinstaller-hooks-contrib#634) <https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/634>`_) * Add hook for ``python-crfsuite``. (`[#633](pyinstaller/pyinstaller-hooks-contrib#633) <https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/633>`_) * Add hook for ``python-mecab-ko``. (`[#632](pyinstaller/pyinstaller-hooks-contrib#632) <https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/632>`_) * Add hook for ``simplemma``. (`[#629](pyinstaller/pyinstaller-hooks-contrib#629) <https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/629>`_) * Add hook for ``SudachiPy``. (`[#635](pyinstaller/pyinstaller-hooks-contrib#635) <https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/635>`_) * Add hook for ``wordcloud``. (`[#630](pyinstaller/pyinstaller-hooks-contrib#630) <https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/630>`_) <p>Updated hooks </code></pre></p> <ul> <li>Fix an issue with enchant 2 using a different directory (in MacPorts) (<code>[#636](pyinstaller/pyinstaller-hooks-contrib#636) <https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/636></code>_)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/08abf3afe5dabc144e602fde0e4147bce2da1342"><code>08abf3a</code></a> Release v2023.8</li> <li><a href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/6fa4daf780593dfc7f4e1fb1ce33ab86cf197e17"><code>6fa4daf</code></a> Add license to Trove classifiers (<a href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/637">#637</a>)</li> <li><a href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/9a5bad5e0f46a309d7dfa5fa7ef32cbe5a801b8d"><code>9a5bad5</code></a> Scheduled weekly dependency update for week 35 (<a href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/638">#638</a>)</li> <li><a href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/2cb020dd3e94084a9c073aa867f224d2c4de02a4"><code>2cb020d</code></a> Fix an issue where enchant 2 uses a different directory (in MacPorts)</li> <li><a href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/d8aae14dc7eba7a56594d68f47940148f062d689"><code>d8aae14</code></a> hooks: add hook for SudachiPy (<a href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/635">#635</a>)</li> <li><a href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/284ea3724a819899b95b915dc5f81a1fa99bb4a7"><code>284ea37</code></a> hooks: add hook for pymorphy3 (<a href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/634">#634</a>)</li> <li><a href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/f0ff36260698958a47e4b47feb1466b23dcf5bd2"><code>f0ff362</code></a> hooks: add hook for python-crfsuite</li> <li><a href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/16ac9c7c1065b1947664293feb3a591de11749a4"><code>16ac9c7</code></a> hooks: add hook for khmer-nltk</li> <li><a href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/2c9af58df3d99ee1855714d442fe20fda94b0fd6"><code>2c9af58</code></a> hooks: add hook for python-mecab-ko (<a href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/632">#632</a>)</li> <li><a href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/b6966f9ab33eaf058afcb96cd59d230e7b97df75"><code>b6966f9</code></a> ci: ubuntu: update sha256 for MariaDB repository setup script</li> <li>Additional commits viewable in <a href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/compare/2023.7...2023.8">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a hook for jieba which is a Chinese word tokenization library.