Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hooks: add hook for khmer-nltk and python-crfsuite #633

Merged
merged 2 commits into from
Aug 22, 2023
Merged

hooks: add hook for khmer-nltk and python-crfsuite #633

merged 2 commits into from
Aug 22, 2023

Conversation

BLKSerene
Copy link
Contributor

@BLKSerene BLKSerene commented Aug 22, 2023

This PR adds a hook for khmer-nltk, which is a Khmer (Cambodian) natural language processing toolkit.
Another hook for python-crfsuite, which is a python binding to CRFsuite is also added to manage the dependency.

@rokm
Copy link
Member

rokm commented Aug 22, 2023

Looks like this will require a hook for pycrfsuite.

@BLKSerene
Copy link
Contributor Author

@rokm Shall I add another separate hook for pycrfsuite or just add it here?

@rokm
Copy link
Member

rokm commented Aug 22, 2023

It should go in a separate hook, because this error will be encountered by anyone trying to import pycrfsuite. But you can add the hook in this PR, in a separate commit (and you can add additional news fragment called 633.news.1.rst for that change.

@BLKSerene BLKSerene closed this Aug 22, 2023
@BLKSerene BLKSerene reopened this Aug 22, 2023
@BLKSerene BLKSerene changed the title hooks: add hook for khmer-nltk hooks: add hook for khmer-nltk and python-crfsuite Aug 22, 2023
@bwoodsend bwoodsend merged commit f0ff362 into pyinstaller:master Aug 22, 2023
14 checks passed
@BLKSerene BLKSerene deleted the khmer_nltk branch August 22, 2023 10:48
github-actions bot pushed a commit to wxx9248/CIS-Game-Project-2023W that referenced this pull request Aug 30, 2023
…3.8 (#66)

Bumps
[pyinstaller-hooks-contrib](https://github.com/pyinstaller/pyinstaller-hooks-contrib)
from 2023.7 to 2023.8.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/releases">pyinstaller-hooks-contrib's
releases</a>.</em></p>
<blockquote>
<h2>2023.8</h2>
<p>Please see the <a
href="https://www.github.com/pyinstaller/pyinstaller-hooks-contrib/tree/master/CHANGELOG.rst">changelog</a>
for more details</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/blob/master/CHANGELOG.rst">pyinstaller-hooks-contrib's
changelog</a>.</em></p>
<blockquote>
<h2>2023.8 (2023-08-29)</h2>
<p>New hooks</p>
<pre><code>
* Add hook for ``eng_to_ipa``.
(`[#631](pyinstaller/pyinstaller-hooks-contrib#631)

&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/631&gt;`_)
* Add hook for ``jieba``.
(`[#628](pyinstaller/pyinstaller-hooks-contrib#628)

&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/628&gt;`_)
* Add hook for ``khmer-nltk``.
(`[#633](pyinstaller/pyinstaller-hooks-contrib#633)

&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/633&gt;`_)
* Add hook for ``Lingua``.
(`[#626](pyinstaller/pyinstaller-hooks-contrib#626)

&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/626&gt;`_)
* Add hook for ``opencc-python``.
(`[#627](pyinstaller/pyinstaller-hooks-contrib#627)

&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/627&gt;`_)
* Add hook for ``pymorphy3``.
(`[#634](pyinstaller/pyinstaller-hooks-contrib#634)

&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/634&gt;`_)
* Add hook for ``python-crfsuite``.
(`[#633](pyinstaller/pyinstaller-hooks-contrib#633)

&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/633&gt;`_)
* Add hook for ``python-mecab-ko``.
(`[#632](pyinstaller/pyinstaller-hooks-contrib#632)

&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/632&gt;`_)
* Add hook for ``simplemma``.
(`[#629](pyinstaller/pyinstaller-hooks-contrib#629)

&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/629&gt;`_)
* Add hook for ``SudachiPy``.
(`[#635](pyinstaller/pyinstaller-hooks-contrib#635)

&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/635&gt;`_)
* Add hook for ``wordcloud``.
(`[#630](pyinstaller/pyinstaller-hooks-contrib#630)

&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/630&gt;`_)
<p>Updated hooks
</code></pre></p>
<ul>
<li>Fix an issue with enchant 2 using a different directory (in
MacPorts)
(<code>[#636](pyinstaller/pyinstaller-hooks-contrib#636)
&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/636&gt;</code>_)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/08abf3afe5dabc144e602fde0e4147bce2da1342"><code>08abf3a</code></a>
Release v2023.8</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/6fa4daf780593dfc7f4e1fb1ce33ab86cf197e17"><code>6fa4daf</code></a>
Add license to Trove classifiers (<a
href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/637">#637</a>)</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/9a5bad5e0f46a309d7dfa5fa7ef32cbe5a801b8d"><code>9a5bad5</code></a>
Scheduled weekly dependency update for week 35 (<a
href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/638">#638</a>)</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/2cb020dd3e94084a9c073aa867f224d2c4de02a4"><code>2cb020d</code></a>
Fix an issue where enchant 2 uses a different directory (in
MacPorts)</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/d8aae14dc7eba7a56594d68f47940148f062d689"><code>d8aae14</code></a>
hooks: add hook for SudachiPy (<a
href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/635">#635</a>)</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/284ea3724a819899b95b915dc5f81a1fa99bb4a7"><code>284ea37</code></a>
hooks: add hook for pymorphy3 (<a
href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/634">#634</a>)</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/f0ff36260698958a47e4b47feb1466b23dcf5bd2"><code>f0ff362</code></a>
hooks: add hook for python-crfsuite</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/16ac9c7c1065b1947664293feb3a591de11749a4"><code>16ac9c7</code></a>
hooks: add hook for khmer-nltk</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/2c9af58df3d99ee1855714d442fe20fda94b0fd6"><code>2c9af58</code></a>
hooks: add hook for python-mecab-ko (<a
href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/632">#632</a>)</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/b6966f9ab33eaf058afcb96cd59d230e7b97df75"><code>b6966f9</code></a>
ci: ubuntu: update sha256 for MariaDB repository setup script</li>
<li>Additional commits viewable in <a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/compare/2023.7...2023.8">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pyinstaller-hooks-contrib&package-manager=pip&previous-version=2023.7&new-version=2023.8)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants