Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zstandard libraries from hdf5plugin for dclab hook #460

Closed
wants to merge 1 commit into from

Conversation

paulmueller
Copy link
Contributor

@paulmueller paulmueller commented Jul 5, 2022

The package dclab uses the Zstandard compression algorithm HDF5 plugin from the hdf5plugin package. This pull request makes sure that the corresponding dll/so/dylib files are present in the distribution. I am the author of dclab.
https://github.com/ZellMechanik-Dresden/dclab

@paulmueller paulmueller marked this pull request as ready for review July 5, 2022 08:06
@bwoodsend
Copy link
Member

Any reason why this should go in the hook for dclab instead of a hook for hdf5plugin?

@paulmueller
Copy link
Contributor Author

My initial idea was this: If I used a general hook for hdf5plugin, then all of the library files (not only Zstandard) would be added. I intended to only add Zstandard here, because none of the other libraries are required.

But I see that a hook for hdf5plugin might be a better, more general solution, even if it means that it increases the distribution size.

Should I create an hdf5plugin hook instead?

@bwoodsend
Copy link
Member

If hdf5plugin is usable without those extra files then no.

@paulmueller
Copy link
Contributor Author

Then that means yes, because in the most general case, you will need those extra files with hdf5plugin. I will create a hook for hdf5plugin.

@paulmueller paulmueller closed this Jul 5, 2022
@paulmueller paulmueller deleted the patch-1 branch July 6, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants