Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix library duplication in tensorflow v.2.3 and avoid packaging unnecessary files #50

Merged
merged 5 commits into from
Sep 25, 2020

Commits on Sep 23, 2020

  1. hooks: tensorflow: prevent duplication of _pywrap_tensorflow_internal

    On some tensorflow versions (2.3.0 thus far), the
    _pywrap_tensorflow_internal extension module ends up duplicated.
    We pick it up as both an extension module (placed in
    `tensorflow/python` directory) and as a shared library (placed in
    program's root directory). This increases the program size, and
    also prevents the program from running under macOS.
    
    In the problematic versions, the extension module seems to be
    picked up as `tensorflow.python._pywrap_tensorflow_internal`,
    while in others it is picked up as just ˙_pywrap_tensorflow_internal`.
    So we try to work around the duplication by removing the problematic
    entry from `hiddenimports` and adding it to `excludedimports`.
    
    Fixes pyinstaller#49.
    rokm committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    c69e298 View commit details
    Browse the repository at this point in the history
  2. hooks: tensorflow: avoid collecting unnecessary data

    Avoid collecting tensorflow's development headers in `include`
    directory and XLA AOT runtime sources (`xla_aot_runtime_src`).
    
    Also prevent `libtensorflow_framework` shared library from being
    picked up as data to prevent its duplication (it should be
    correctly picked up as a shared library by dependency scanner).
    rokm committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    3b99b78 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    70ae5e9 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. Appease the linter

    rokm committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    baf992c View commit details
    Browse the repository at this point in the history
  2. Added news fragment for PR.

    rokm committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    37b1055 View commit details
    Browse the repository at this point in the history