Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CtkMessagebox hook. #619

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Add CtkMessagebox hook. #619

merged 2 commits into from
Jul 31, 2023

Conversation

pcroland
Copy link
Contributor

No description provided.

Copy link
Member

@bwoodsend bwoodsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a news entry, and preferably a test. See the readme.

@pcroland pcroland requested a review from bwoodsend July 30, 2023 16:18
@keraprogress
Copy link

keraprogress commented Jul 31, 2023

Run flake8 -v
flake8.checker            MainProcess    169 INFO     Making checkers
flake8.main.application   MainProcess   1306 INFO     Finished running
flake8.main.application   MainProcess   1307 INFO     Reporting errors
flake8.main.application   MainProcess   1310 INFO     Found a total of 58 violations and reported 1
./src/_pyinstaller_hooks_contrib/hooks/stdhooks/hook-pylint.py:54:99: E231 missing whitespace after ','
Error: Process completed with exit code 1.

This seems like a flake8 bug. These are the lines in hook-pylint.py that flake8 doesn't like:

from PyInstaller.utils.hooks import collect_data_files, collect_submodules, is_module_or_submodule,\
    get_module_file_attribute

@rokm
Copy link
Member

rokm commented Jul 31, 2023

This seems like a flake8 bug. These are the lines in hook-pylint.py that flake8 doesn't like:

Indeed, and this seems to have been changed in flake8 6.1.0 that was released two days ago. Not this PR's problem, though.

@rokm rokm merged commit f9a0d64 into pyinstaller:master Jul 31, 2023
1 of 2 checks passed
github-actions bot pushed a commit to wxx9248/Pickle-Rush that referenced this pull request Aug 18, 2023
…3.7 (#64)

Bumps
[pyinstaller-hooks-contrib](https://github.com/pyinstaller/pyinstaller-hooks-contrib)
from 2023.6 to 2023.7.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/releases">pyinstaller-hooks-contrib's
releases</a>.</em></p>
<blockquote>
<h2>2023.7</h2>
<p>Please see the <a
href="https://www.github.com/pyinstaller/pyinstaller-hooks-contrib/tree/master/CHANGELOG.rst">changelog</a>
for more details</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/blob/master/CHANGELOG.rst">pyinstaller-hooks-contrib's
changelog</a>.</em></p>
<blockquote>
<h2>2023.7 (2023-08-18)</h2>
<p>New hooks</p>
<pre><code>
* Add a hook for ``psutil``, which has platform-dependent exclude list.
(`[#623](pyinstaller/pyinstaller-hooks-contrib#623)

&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/623&gt;`_)
* Add hook for CtkMessagebox.
(`[#619](pyinstaller/pyinstaller-hooks-contrib#619)

&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/619&gt;`_)
* Add hook for Litestar
(`[#625](pyinstaller/pyinstaller-hooks-contrib#625)

&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/625&gt;`_)
<p>Updated hooks
</code></pre></p>
<ul>
<li>Update <code>graphql_query</code> hook for compatibility with
<code>graphql-query</code>
v1.2.0.
(<code>[#621](pyinstaller/pyinstaller-hooks-contrib#621)
&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/621&gt;</code>_)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/3cbfec0485eb6a8a62d434e90c4df11490847d05"><code>3cbfec0</code></a>
Release v2023.7</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/98e6d30c714251c7fdc10dc4399dd04b38035e48"><code>98e6d30</code></a>
Hook for Litestar (<a
href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/625">#625</a>)</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/c63fef8e0ea8049a904e8ee3a489093e8a19cf76"><code>c63fef8</code></a>
Scheduled weekly dependency update for week 33 (<a
href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/624">#624</a>)</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/19df430ac19ed6233a70d83ee9975e7045c727b2"><code>19df430</code></a>
Add hook for psutil (<a
href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/623">#623</a>)</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/f1f3cc900be79daac23575b57183fe42b8b55943"><code>f1f3cc9</code></a>
Scheduled weekly dependency update for week 32 (<a
href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/622">#622</a>)</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/943da11b7291e36caaded6e58bc93f4e2b176a72"><code>943da11</code></a>
hooks: update graphql_query hook for compatibility with v1.2.0</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/80411aaa391c4327a71b2968089c175eba01fbca"><code>80411aa</code></a>
Scheduled weekly dependency update for week 31 (<a
href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/620">#620</a>)</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/f9a0d641ebac86d0a3772fd5888fb88e7c87aff8"><code>f9a0d64</code></a>
Add CtkMessagebox hook. (<a
href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/619">#619</a>)</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/bdd0fce440b39250c72c666004566743f7ab8af0"><code>bdd0fce</code></a>
Scheduled weekly dependency update for week 30 (<a
href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/618">#618</a>)</li>
<li>See full diff in <a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/compare/2023.6...2023.7">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pyinstaller-hooks-contrib&package-manager=pip&previous-version=2023.6&new-version=2023.7)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants