Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hooks: add hook for falcon #703

Merged
merged 1 commit into from
Feb 16, 2024
Merged

hooks: add hook for falcon #703

merged 1 commit into from
Feb 16, 2024

Conversation

davetapley
Copy link
Contributor

closes #702

@davetapley davetapley force-pushed the hook-for-falcon branch 2 times, most recently from 9524179 to 2e0d56a Compare February 15, 2024 21:02
@bwoodsend
Copy link
Member

Hmm, it looks like having both the original .py files and the cythonized .so files available is somehow causing neither to be found. Running rm env/lib/python3.12/site-packages/falcon/**.py makes the tests pass. There's presumably a PyInstaller bug in here although, depending on where it comes from, it may not actually be fixable. Grrr, there's a special place in hell for packages which optionally squirt themselves through cython instead of just cythonizing the bottlenecks...

@rokm
Copy link
Member

rokm commented Feb 16, 2024

Running rm env/lib/python3.12/site-packages/falcon/**.py makes the tests pass.

Only because falcon.__init__ is not cythonized, and so the package becomes a namespace package, whose import is a no-op.

But on the other hand, since falcon.__init__ is not cythonized, we should automatically pick up the falcon.app_helpers that it imports...

@rokm
Copy link
Member

rokm commented Feb 16, 2024

But on the other hand, since falcon.__init__ is not cythonized, we should automatically pick up the falcon.app_helpers that it imports...

Actually, scratch that. The falcon.app_helpers is imported in falcon.app, which is cythonized.

@davetapley
Copy link
Contributor Author

@bwoodsend @rokm the cython discussion is a bit over my head, but I fixed the ,, let me know if there's anything else I can do 😁

@bwoodsend bwoodsend merged commit 5694f23 into pyinstaller:master Feb 16, 2024
14 checks passed
@bwoodsend
Copy link
Member

Thanks @davetapley!

github-actions bot pushed a commit to wxx9248/Pickle-Rush that referenced this pull request Mar 1, 2024
@dependabot
Dependency Updates: Bump pyinstaller-hooks-contrib from 2024.1 to 202…
0f41f11 
…4.2 (#89)

Bumps
[pyinstaller-hooks-contrib](https://github.com/pyinstaller/pyinstaller-hooks-contrib)
from 2024.1 to 2024.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/releases">pyinstaller-hooks-contrib's
releases</a>.</em></p>
<blockquote>
<h2>2024.2</h2>
<p>Please see the <a
href="https://www.github.com/pyinstaller/pyinstaller-hooks-contrib/tree/master/CHANGELOG.rst">changelog</a>
for more details</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/blob/master/CHANGELOG.rst">pyinstaller-hooks-contrib's
changelog</a>.</em></p>
<blockquote>
<h2>2024.2 (2024-02-29)</h2>
<p>New hooks</p>
<pre><code>
* Add a hook for ``iso639-lang``, to collect data files
(`[#707](pyinstaller/pyinstaller-hooks-contrib#707)

&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/707&gt;`_)
* Add hook for ``falcon``, which has hidden imports.
(`[#703](pyinstaller/pyinstaller-hooks-contrib#703)

&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/703&gt;`_)
<p>Updated hooks
</code></pre></p>
<ul>
<li>Update <code>pyqtgraph</code> hook to use the helper for automatic
Qt bindings
selection and exclusion from PyInstaller &gt;= 6.5 (no-op with earlier
versions). This should help preventing multiple Qt bindings from
being collected into frozen application.
(<code>[#710](pyinstaller/pyinstaller-hooks-contrib#710)
&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/710&gt;</code>_)</li>
<li>Update the exclude list for GUI frameworks in the
<code>IPython</code> hook with
additional contemporary Qt bindings (<code>PySide2</code>,
<code>PySide6</code>, and
<code>PyQt6</code>).
(<code>[#708](pyinstaller/pyinstaller-hooks-contrib#708)
&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/708&gt;</code>_)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/1d8875b388430725657d08aaf0ab739d66b2ac81"><code>1d8875b</code></a>
Release v2024.2</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/2f8969639db645e24122e89fc2d08d7cc17a646b"><code>2f89696</code></a>
hooks: update pyqtgraph hook to use Qt bindings selection helper</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/c1fb9cbc38aa8306f71a59b4025c91403fda7158"><code>c1fb9cb</code></a>
Scheduled weekly dependency update for week 08 (<a
href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/709">#709</a>)</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/8119cfb61babc4099a2536eaad1de6ebc9f19a10"><code>8119cfb</code></a>
hooks: IPython: update exclude list for GUI frameworks</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/47c1e42e0860635223e62679d6b078e89dd24c66"><code>47c1e42</code></a>
Add hook for iso639-lang (<a
href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/707">#707</a>)</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/6bc3a3301151ca827df2ec9b1ea2af1826f1dc54"><code>6bc3a33</code></a>
Scheduled weekly dependency update for week 07 (<a
href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/706">#706</a>)</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/9529e1bc6db6000c673ef1de6929266e5cf3d6cd"><code>9529e1b</code></a>
README: Hide CI/CD triggering section</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/b1f846c692caece90886e9ea4b96714ac12a9c9d"><code>b1f846c</code></a>
README: Add installing pyinstaller to developer guide</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/5694f23472e2d0283618effa81e42035195246cc"><code>5694f23</code></a>
hooks: add hook for falcon</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/6680d2e6a88d6684fe13d389ab1831936413a3b0"><code>6680d2e</code></a>
Scheduled weekly dependency update for week 06 (<a
href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/701">#701</a>)</li>
<li>See full diff in <a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/compare/2024.1...2024.2">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pyinstaller-hooks-contrib&package-manager=pip&previous-version=2024.1&new-version=2024.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rokm rokm rokm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Falcon hook
3 participants
@davetapley @bwoodsend @rokm