-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QOL: Config run should handle shell paths with spaces #989
base: main
Are you sure you want to change the base?
Conversation
Any suggestions on this change? @bitprophet , @kuwv . Thank you |
from invoke.terminals import ( | ||
pty_size, | ||
bytes_to_read, | ||
WINDOWS, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Objects should precede functions.
.coveragerc
Outdated
@@ -3,4 +3,6 @@ branch = True | |||
include = | |||
invoke/* | |||
tests/* | |||
omit = invoke/vendor/* | |||
omit = | |||
invoke/shims.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverage is omitted for vendor-ed dependencies because those are separately developed modules. I don't think this should be omitted
I don't really know windows. Can you explain what the issue is here? Thanks nm, I just read this issue. |
Description
terminals.get_short_path_name()
utility function that usesctypes.windll.kernel32.GetShortPathNameW
to get short path form for long path. Only applies to Windows-based systems; on Unix this is a pass-thru.Runner._setup()
function to use the new utility function when settingself.opts["shell"]
on windows platform.skip_if_posix()
decorator function that skips the decorated test when on UNIX.Runner_.shell
test class to check the new behavior.terminals
test class to check the new behavior.Demo
With invoke main:
cmd.exe
pwsh.exe
, long format does not.With invoke fork:
cmd.exe
pwsh.exe