Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout fails #59

Closed
jan-janssen opened this issue Nov 20, 2023 · 8 comments
Closed

Checkout fails #59

jan-janssen opened this issue Nov 20, 2023 · 8 comments
Assignees

Comments

@jan-janssen
Copy link
Member

Run actions/checkout@v3
  with:
    fetch-depth: 0
    repository: pyiron/pyiron_vasp
    ssh-strict: true
    persist-credentials: true
    clean: true
    sparse-checkout-cone-mode: true
    fetch-tags: false
    lfs: false
    submodules: false
    set-safe-directory: true
Error: Input required and not supplied: token

For example in https://github.com/pyiron/pyiron_contrib or https://github.com/pyiron/pyiron_vasp

@liamhuber
Copy link
Member

I won't be able to look at this until tomorrow at the absolute earliest; the first link doesn't indicate the error clearly to me, and the second link is a 404.

@jan-janssen
Copy link
Member Author

All the pull requests in pyiron contrib fail pyiron/pyiron_contrib#912 - pyiron/pyiron_contrib#918

@jan-janssen
Copy link
Member Author

The second is currently a private repository

@liamhuber
Copy link
Member

So this seems to only be occurring for the dependabot PRs (possibly for other non-member fork PRs, but at least dependabot is the thing that's causing trouble), there's no trouble on my own PRs.

In addition to the token failure, UpdateDependabotPR / pyiron / dependabot (pull_request_target): Run pyiron/actions/update-env-files@main is failing with

Traceback (most recent call last):
  File "/home/runner/work/_actions/pyiron/actions/main/update-env-files/../.support/update_environment.py", line 116, in <module>
    raise ValueError(f"Title of a dependabot PR 'Bump <package> from <version> to <version>' expected, "
ValueError: Title of a dependabot PR 'Bump <package> from <version> to <version>' expected, but got Bump pyiron-base from 0.6.8 to 0.6.9 .ci_support/environment.yml /home/runner/work/_actions/pyiron/actions/main/update-env-files/../.support/pypi_vs_conda_names.json
Error: Process completed with exit code 1.

Which I guess is related to #56. Could that failure be causing the other tests to break?

@liamhuber
Copy link
Member

Ok, indeed, check here -- the dependabot commit has always been failing the CI with such a message! It's just that after that, the centralized CI makes another commit propagating the dependabot changes to other files, and runner has all the necessary secrets!

@liamhuber
Copy link
Member

Indeed, this is just the new issue #61 letting us once again see the known issue #44

@liamhuber
Copy link
Member

Ah, ok, not quite just those two as dependabot should be getting extra power from on: pull_request_target. Let me see if that is (a) real and not just me failing to notice it was the runner commits that were actually working, and (b) different enough from #44 to warrant reopening this...

@liamhuber
Copy link
Member

Ok, so the fork commit from dependabot itself fails the push-to-main CI, but it safely triggers pyiron runner to commit other updates and these have the power to run the push-to-main CI. So #44 is still interesting for non-dependabot forks, but solving #61 really is the heart of this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants