Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Dependabot PR titles are not parsing #61

Closed
liamhuber opened this issue Nov 22, 2023 · 3 comments · Fixed by #62
Closed

🐛 Dependabot PR titles are not parsing #61

liamhuber opened this issue Nov 22, 2023 · 3 comments · Fixed by #62

Comments

@liamhuber
Copy link
Member

We get

Traceback (most recent call last):
  File "/home/runner/work/_actions/pyiron/actions/main/update-env-files/../.support/update_environment.py", line 116, in <module>
    raise ValueError(f"Title of a dependabot PR 'Bump <package> from <version> to <version>' expected, "
ValueError: Title of a dependabot PR 'Bump <package> from <version> to <version>' expected, but got Bump pyiron-base from 0.6.8 to 0.6.9 .ci_support/environment.yml /home/runner/work/_actions/pyiron/actions/main/update-env-files/../.support/pypi_vs_conda_names.json
Error: Process completed with exit code 1.

Which I guess is a result of #56.

I'm working on it right now, but @niklassiemer FYI.

@liamhuber
Copy link
Member Author

The call is this: python $GITHUB_ACTION_PATH/../.support/update_environment.py $PR_TITLE .ci_support/environment.yml $GITHUB_ACTION_PATH/../.support/pypi_vs_conda_names.json

Which expands to: Bump pyiron-base from 0.6.8 to 0.6.9 .ci_support/environment.yml /home/runner/work/_actions/pyiron/actions/main/update-env-files/../.support/pypi_vs_conda_names.json

This is only 8 long, but here we're filtering out lengths <10.

@liamhuber
Copy link
Member Author

So there's a 9th element from the arg parsing that we ignore, and that's why the old code had != 9. I think we just wound up with an off-by-one error in our length limits.

@liamhuber
Copy link
Member Author

The real take-home for me here is that we need some better way -- honestly, a way -- to test changes made to this repo. At a minimum, I think we need to version this sucker, have all the downstream repos point to a particular version instead of main, then roll out changes to a test repo first. But that is still super basic compared to having some sort of real CI for our centralized CI here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant