Skip to content

remove unused parameter terminate_tasks_on_shutdown #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jan-janssen merged 1 commit into from
Jul 16, 2025
Merged

remove unused parameter terminate_tasks_on_shutdown #735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion executorlib/executor/flux.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,6 @@ def __init__(
plot_dependency_graph: bool = False,
plot_dependency_graph_filename: Optional[str] = None,
log_obj_size: bool = False,
terminate_tasks_on_shutdown: bool = True,
):
"""
The executorlib.FluxClusterExecutor leverages either the message passing interface (MPI), the SLURM workload
Expand Down
2 changes: 0 additions & 2 deletions executorlib/executor/slurm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ def __init__(
plot_dependency_graph: bool = False,
plot_dependency_graph_filename: Optional[str] = None,
log_obj_size: bool = False,
terminate_tasks_on_shutdown: bool = True,
):
"""
The executorlib.SlurmClusterExecutor leverages either the message passing interface (MPI), the SLURM workload
Expand Down Expand Up @@ -281,7 +280,6 @@ def __init__(
plot_dependency_graph: bool = False,
plot_dependency_graph_filename: Optional[str] = None,
log_obj_size: bool = False,
terminate_tasks_on_shutdown: bool = True,
):
"""
The executorlib.SlurmJobExecutor leverages either the message passing interface (MPI), the SLURM workload
Expand Down
2 changes: 0 additions & 2 deletions tests/test_fluxclusterexecutor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ def test_executor(self):
resource_dict={"cores": 2, "cwd": "executorlib_cache"},
block_allocation=False,
cache_directory="executorlib_cache",
terminate_tasks_on_shutdown=False,
) as exe:
cloudpickle_register(ind=1)
fs1 = exe.submit(mpi_funct, 1)
Expand All @@ -51,7 +50,6 @@ def test_executor_no_cwd(self):
resource_dict={"cores": 2},
block_allocation=False,
cache_directory="executorlib_cache",
terminate_tasks_on_shutdown=True,
) as exe:
cloudpickle_register(ind=1)
fs1 = exe.submit(mpi_funct, 1)
Expand Down
2 changes: 0 additions & 2 deletions tests/test_slurmclusterexecutor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ def test_executor(self):
resource_dict={"cores": 2, "cwd": "executorlib_cache", "submission_template": submission_template},
block_allocation=False,
cache_directory="executorlib_cache",
terminate_tasks_on_shutdown=False,
) as exe:
cloudpickle_register(ind=1)
fs1 = exe.submit(mpi_funct, 1)
Expand All @@ -64,7 +63,6 @@ def test_executor_no_cwd(self):
resource_dict={"cores": 2, "submission_template": submission_template},
block_allocation=False,
cache_directory="executorlib_cache",
terminate_tasks_on_shutdown=True,
) as exe:
cloudpickle_register(ind=1)
fs1 = exe.submit(mpi_funct, 1)
Expand Down
Loading