Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release dependence on ipywidgets #820

Closed
wants to merge 2 commits into from

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Oct 13, 2022

Checklist:

  • Wait for nglview to get a conda release that is either ipywidgets 8-compliant, or does the pinning for us

@jan-janssen jan-janssen marked this pull request as draft October 13, 2022 16:56
@coveralls
Copy link

coveralls commented Oct 13, 2022

Pull Request Test Coverage Report for Build 3622704003

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.662%

Totals Coverage Status
Change from base Build 3622625190: 0.0%
Covered Lines: 12114
Relevant Lines: 17643

💛 - Coveralls

@liamhuber
Copy link
Member

You need this pin for nglview to work. The problem is that nglview is inconsistent with the latest version of ipywidgets, and while they have merged Marvin's patch that pins the dependency there, there has been no new release of nglview since then. So what happens is that conda sees our nglview dependency and installs the latest version, then sees nglview's dependency on ipywidgets and installs the latest version of that and voila, we have our error.

They have a couple issues on this error already. I'm don't know exactly what they're release process looks like, but I just learned now that they have a conda feedstock PR since August, but as of September apparently no one has time to debug it.

So for now we need the pin.

@liamhuber liamhuber closed this Oct 13, 2022
@jan-janssen jan-janssen reopened this Oct 13, 2022
@jan-janssen
Copy link
Member Author

So for now we need the pin.

That is why I keep the pull request a draft.

@hainm
Copy link

hainm commented Oct 17, 2022

but as of September apparently nglviewer/nglview#1032 (comment).

yay. Sorry about this. We need someone volunteering working on that.
PS: If someone would like to handle the pip release, please let me know so I will ping Alexander Rose to add your pypi account as one of the maintainers. cheers.

@stale
Copy link

stale bot commented Nov 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 1, 2022
@stale stale bot removed the stale label Dec 5, 2022
@stale
Copy link

stale bot commented Dec 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 21, 2022
@stale stale bot closed this Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants